Fixed macOS keychain access when using Python 3 · einsteinx2/python-github-backup@81a2f76 · GitHub

einsteinx2 / python-github-backup Public

forked from josegonzalez/python-github-backup

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 81a2f76

Browse filesBrowse the repository at this point in the historyBrowse files

einsteinx2

committed

Fixed macOS keychain access when using Python 3

Python 3 is returning bytes rather than a string, so the string concatenation to create the auth variable was throwing an exception which the script was interpreting to mean it couldn't find the password. Adding a conversion to string first fixed the issue.

1 parent 252c254 commit 81a2f76
Copy full SHA for 81a2f76

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• bin
  • github-backup

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎bin/github-backup‎

Copy file name to clipboardExpand all lines: bin/github-backup

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -337,6 +337,8 @@ def get_auth(args, encode=True):
337	337	'-s', args.osx_keychain_item_name,
338	338	'-a', args.osx_keychain_item_account,
339	339	'-w'], stderr=devnull).strip())
	340	+ if not PY2:
	341	+ token = token.decode('utf-8')
340	342	auth = token + ':' + 'x-oauth-basic'
341	343	except:
342	344	log_error('No password item matching the provided name and account could be found in the osx keychain.')

0 commit comments

Comments

0 (0)