FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing develop...feat/admin-ui-render-disables · ether/etherpad · GitHub

/ etherpad Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ether/etherpad
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: ether/etherpad
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/admin-ui-render-disables
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on May 2, 2026

  1. feat(admin): surface ep.json disables in /admin plugin browser 

    Companion to ether/ether.github.com#395 — the admin UI's "available
plugins" listing now also renders the plugin's declared `disables`
(see doc/PLUGIN_FEATURE_DISABLES.md) so an operator about to click
Install sees the same warning as a user browsing etherpad.org/plugins:
"Disables: chat".

- src/node/types/PackageInfo.ts: optional `disables?: string[]` on
  the registry payload type.
- admin/src/pages/Plugin.ts: same on the admin-side PluginDef.
- admin/src/pages/HomePage.tsx: render an amber callout under the
  description when `disables` is present and non-empty. Plugins
  without a disables field render unchanged.

The plugin-registry build pipeline still has to start surfacing
`disables` from ep.json into plugins.json/plugins.viewer.json — until
that lands, the new callout no-ops everywhere, which is fine.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
    JohnMcLear and claude committed May 2, 2026
    Configuration menu
    Copy the full SHA
    a0f28fd View commit details
    Browse the repository at this point in the history

  2. i18n + a11y for admin disables warning (review feedback) 

    Replace the hardcoded "Disables:" label and the inline title attribute
with proper i18n keys (admin_plugins.disables.label,
admin_plugins.disables.warning_title) and add role="alert" so screen
readers announce the warning instead of treating it as visual noise.

Per user review on #7649: "we should display it as a warning only if
a plugin disables a test... Also i18n!!! Always remember to do i18n."

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
    JohnMcLear and claude committed May 2, 2026
    Configuration menu
    Copy the full SHA
    803b323 View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL