FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

better error messages · explodingbarrel/node-querystring@fe2efe7 · GitHub

Commit fe2efe7

Browse files
committed
better error messages
1 parent 9d61088 commit fe2efe7

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

‎lib/querystring.js‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ exports.parse = function(str){
9191
var stringify = exports.stringify = function(obj, prefix) {
9292
var ret = [];
9393
if (Array.isArray(obj)) {
94-
if (typeof prefix === 'undefined' ) {
95-
throw new Error("Value must be a hash");
96-
}
94+
if (!prefix) throw new TypeError('stringify expects an object');
9795
for (var i = 0; i < obj.length; i++) {
9896
ret.push( stringify(obj[i], prefix + '[]') );
9997
}
@@ -109,9 +107,7 @@ var stringify = exports.stringify = function(obj, prefix) {
109107
}
110108
return ret.join("&");
111109
} else if ('string' == typeof obj) {
112-
if (typeof prefix === 'undefined') {
113-
throw new Error("Value must be a hash");
114-
}
110+
if (!prefix) throw new TypeError('stringify expects an object');
115111
return prefix + '=' + encodeURIComponent(obj);
116112
} else {
117113
return prefix;

‎test/stringify.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ var qs = require('../')
4444
{query_string: 'user[name][first]=tj&user[name][last]=holowaychuk', parsed: { user: { name: { first: 'tj', last: 'holowaychuk' }}}}
4545
],
4646
'errors': [
47-
{parsed: 'foo=bar', message: 'Value must be a hash'},
48-
{parsed: ['foo','bar'], message: 'Value must be a hash'}
47+
{ parsed: 'foo=bar', message: 'stringify expects an object' },
48+
{ parsed: ['foo', 'bar'], message: 'stringify expects an object' }
4949
]
5050
};
5151

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL