FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

getVersionSync test fails in appveyor · Issue #158 · extrabacon/python-shell · GitHub

Repository navigation

getVersionSync test fails in appveyor #158

Description

It says that the version is a empty string. No idea why - passes locally. I should try using a different computer and seeing if it passes there.

The other interesting thing is that al the tests passed on ubuntu. Why would the test only fail on windows? I'm using a windows computer currently so it should fail locally if that's the case.

Activity

  1. Almenon commented on Oct 13, 2018

    CollaboratorAuthor

    I just tried on a different computer and it passes locally there too :/

  2. Almenon commented on Oct 13, 2018

    CollaboratorAuthor

    maybe it's because I'm on a different version of node. Ideally I should be doing my tests against a matrix of different node & python versions.

  3. Almenon commented on Oct 13, 2018

    CollaboratorAuthor

    it looks like getverysionsync also fails with python 2

    https://ci.appveyor.com/project/Almenon/python-shell/build/job/7h74qfvwjq2gpe57

  4. Almenon commented on Oct 13, 2018

    CollaboratorAuthor

    and fails with python 3 and node 10 too. So it's not related to the python/node version

    https://ci.appveyor.com/project/Almenon/python-shell/build/job/do630jekia3ayplq

  5. Almenon commented on Nov 18, 2018

    CollaboratorAuthor

    Not sure how I didn't notice it but all the tests are failing :/

  6. Almenon commented on Nov 18, 2018

    CollaboratorAuthor

    All of the ubuntu tests are passing now with 61a8fc9

  7. added a commit that references this issue on Dec 18, 2018
  8. Almenon commented on Dec 18, 2018

    CollaboratorAuthor

    I've decided to comment them out on master untill someone fixes them. The methods the tests test are not very important so if the unit tests don't run it's not that big of a deal. Having a 100% passing unit test suite is more important.

  9. Almenon commented on Dec 19, 2018

    CollaboratorAuthor

    They still work, just not in appveyor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL