fix: improve parsing bytewax job status · fbad/feast@5983f40 · GitHub

fbad / feast Public

forked from feast-dev/feast

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5983f40

Browse filesBrowse the repository at this point in the historyBrowse files

sudohainguyen

authored and

achals

committed

fix: improve parsing bytewax job status

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>

1 parent 9cf9d96 commit 5983f40
Copy full SHA for 5983f40

1 file changed

+16-7Lines changed: 16 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• sdk/python/feast/infra/materialization/contrib/bytewax
  • bytewax_materialization_job.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_job.py‎

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_job.py

+16-7Lines changed: 16 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -35,13 +35,22 @@ def status(self):
35	35	if job_status.active is not None:
36	36	if job_status.completion_time is None:
37	37	return MaterializationJobStatus.RUNNING
38		- elif job_status.failed is not None:
39		- self._error = Exception(f"Job {self.job_id()} failed")
40		- return MaterializationJobStatus.ERROR
41		- elif job_status.active is None:
42		- if job_status.completion_time is not None:
43		- if job_status.conditions[0].type == "Complete":
44		- return MaterializationJobStatus.SUCCEEDED
	38	+ else:
	39	+ if (
	40	+ job_status.completion_time is not None
	41	+ and job_status.conditions[0].type == "Complete"
	42	+ ):
	43	+ return MaterializationJobStatus.SUCCEEDED
	44	+
	45	+ if (
	46	+ job_status.conditions is not None
	47	+ and job_status.conditions[0].type == "Failed"
	48	+ ):
	49	+ self._error = Exception(
	50	+ f"Job {self.job_id()} failed with reason: "
	51	+ f"{job_status.conditions[0].message}"
	52	+ )
	53	+ return MaterializationJobStatus.ERROR
45	54	return MaterializationJobStatus.WAITING
46	55
47	56	def should_be_retried(self):

0 commit comments

Comments

0 (0)