Repository navigation
Commit b519d00
fix: Map Postgres real to FLOAT instead of DOUBLE
Postgres real is a single-precision float4 column, but
pg_type_to_feast_value_type mapped real to ValueType.DOUBLE (and real[] to
DOUBLE_LIST), silently widening the inferred schema to float64. The mssql,
oracle, and trino type maps in the same module all map real to FLOAT; only
Postgres diverged. Map real to FLOAT and real[] to FLOAT_LIST to match.
Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>1 parent d269946 commit b519d00
2 files changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2047,7 +2047,7 @@ def pg_type_to_feast_value_type(type_str: str) -> ValueType: | |||
| 2047 | 2047 | "bigint": ValueType.INT64, | |
| 2048 | 2048 | "smallint": ValueType.INT32, | |
| 2049 | 2049 | "integer": ValueType.INT32, | |
| 2050 | - "real": ValueType.DOUBLE, | ||
| 2050 | + "real": ValueType.FLOAT, | ||
| 2051 | 2051 | "double precision": ValueType.DOUBLE, | |
| 2052 | 2052 | "boolean[]": ValueType.BOOL_LIST, | |
| 2053 | 2053 | "bytea[]": ValueType.BYTES_LIST, | |
@@ -2058,7 +2058,7 @@ def pg_type_to_feast_value_type(type_str: str) -> ValueType: | |||
| 2058 | 2058 | "text[]": ValueType.STRING_LIST, | |
| 2059 | 2059 | "character[]": ValueType.STRING_LIST, | |
| 2060 | 2060 | "bigint[]": ValueType.INT64_LIST, | |
| 2061 | - "real[]": ValueType.DOUBLE_LIST, | ||
| 2061 | + "real[]": ValueType.FLOAT_LIST, | ||
| 2062 | 2062 | "double precision[]": ValueType.DOUBLE_LIST, | |
| 2063 | 2063 | "character": ValueType.STRING, | |
| 2064 | 2064 | "character varying": ValueType.STRING, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -541,6 +541,11 @@ def test_pg_type_to_feast_value_type_json_array(self): | |||
| 541 | 541 | assert pg_type_to_feast_value_type("json[]") == ValueType.MAP_LIST | |
| 542 | 542 | assert pg_type_to_feast_value_type("jsonb[]") == ValueType.MAP_LIST | |
| 543 | 543 | ||
| 544 | + def test_pg_type_to_feast_value_type_real(self): | ||
| 545 | + """Postgres real is single-precision (float4), so it maps to FLOAT, not DOUBLE.""" | ||
| 546 | + assert pg_type_to_feast_value_type("real") == ValueType.FLOAT | ||
| 547 | + assert pg_type_to_feast_value_type("real[]") == ValueType.FLOAT_LIST | ||
| 548 | + | ||
| 544 | 549 | def test_snowflake_variant_to_map(self): | |
| 545 | 550 | """Test that Snowflake VARIANT/OBJECT types convert to ValueType.MAP.""" | |
| 546 | 551 | assert snowflake_type_to_feast_value_type("VARIANT") == ValueType.MAP | |
0 commit comments