FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add annotations to cronjob CRDs by FredericKayser · Pull Request #5701 · feast-dev/feast · GitHub

/ feast Public

feat: Add annotations to cronjob CRDs - #5701

Merged
franciscojavierarceo merged 6 commits into
feast-dev:masterfrom
FredericKayser:feat/add-annotations-to-cronjob-crds
Oct 29, 2025
ConversationCommits (6)ChecksFiles changed
Merged

feat: Add annotations to cronjob CRDs#5701
franciscojavierarceo merged 6 commits into
feast-dev:masterfrom
FredericKayser:feat/add-annotations-to-cronjob-crds

Conversation

FredericKayser commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR adds support for custom annotations on the CronJob resource in the FeatureStore CRD. This enhancement allows users to specify Kubernetes annotations for CronJobs deployed by the Feast operator, which is useful for:

  • Integration with monitoring and observability tools
  • Policy enforcement and compliance tooling
  • Service mesh configuration
  • Custom operator integrations that use annotations for configuration

The annotations field has been added to both the spec and status sections of the CronJob definition in the FeatureStore CRD.

FredericKayser requested a review from a team as a code owner October 28, 2025 16:35
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from cc7c177 to 4b53c5f Compare October 28, 2025 16:35
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This pull request adds support for custom annotations on CronJob metadata in the Feast operator's FeatureStore CRD. The change allows users to specify additional Kubernetes annotations that will be applied to CronJob resources created by the operator.

Key Changes:

  • Added annotations field to the FeastCronJob schema definition in the CRD

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from 399d62c to 01a8854 Compare October 28, 2025 19:40
FredericKayser marked this pull request as draft October 28, 2025 19:47
FredericKayser marked this pull request as ready for review October 28, 2025 19:50
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/feast-operator/internal/controller/services/cronjob.go
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/feast-operator/internal/controller/services/cronjob.go Outdated
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from e01a3fb to be90322 Compare October 29, 2025 13:45
feat: Add annotations to cronjob CRDs
4d18e38 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Implement handling of annotations
6032da7 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Add auto-generated files
7ca033a 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Implement changes from review
f960b54 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Implement changes from review
432aab3 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from be90322 to 432aab3 Compare October 29, 2025 13:47

FredericKayser commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo do you have any idea why the CI fails now? The failure doesn't really seem to be related to my changes.

franciscojavierarceo merged commit be6e6c2 into feast-dev:master Oct 29, 2025
30 of 31 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL