Expose join time-range to python API - #900
Draft
loomlike wants to merge 8 commits into
Draft
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
…p range and fix issues Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
jaymo001
force-pushed
the
main
branch
2 times, most recently
from
635e33f to
77571fd
Compare
December 7, 2022 17:28
jaymo001
force-pushed
the
jumin/support_relative_time_join
branch
from
5c0da25 to
5f3dd14
Compare
December 7, 2022 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #899
to expose join time range functionality to python API.
I'm making this as a draft PR to open discussion about join config and fix potential issues -- currently, relative and absolute time range doesn't have any effect while useLatestFeatureData works.
Please check python's unit-tests (feathr_project/test/unit/definition/test_settings.py) and integration test (feathr_project/test/integration/test_observation_settings.py) to see if the function is implemented correctly, align with the join format.
Regarding an expected behavior of useLatestFeatureData, I opened another issue #898.
How was this PR tested?
Unit and integration tests
Does this PR introduce any user-facing changes?