Added support for args and kwargs when using the public bigquery proxy · feibyte/docker-python@ae4a0ec · GitHub

feibyte / docker-python Public

forked from Kaggle/docker-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ae4a0ec

Browse filesBrowse the repository at this point in the historyBrowse files

Sam Harris

committed

Added support for args and kwargs when using the public bigquery proxy

1 parent e8abf11 commit ae4a0ec
Copy full SHA for ae4a0ec

2 files changed

+9-2Lines changed: 9 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• patches
  • kaggle_gcp.py
• tests
  • test_bigquery.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎patches/kaggle_gcp.py‎

Copy file name to clipboardExpand all lines: patches/kaggle_gcp.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -57,12 +57,12 @@ class PublicBigqueryClient(bigquery.client.Client):
57	57	client = PublicBigqueryClient()
58	58	"""
59	59
60		- def __init__(self):
	60	+ def __init__(self, *args, **kwargs):
61	61	data_proxy_project = os.getenv("KAGGLE_DATA_PROXY_PROJECT")
62	62	anon_credentials = credentials.AnonymousCredentials()
63	63	anon_credentials.refresh = lambda *args: None
64	64	super().__init__(
65		- project=data_proxy_project, credentials=anon_credentials
	65	+ project=data_proxy_project, credentials=anon_credentials, *args, **kwargs
66	66	)
67	67	# TODO: Remove this once https://github.com/googleapis/google-cloud-python/issues/7122 is implemented.
68	68	self._connection = _DataProxyConnection(self)

Collapse file

‎tests/test_bigquery.py‎

Copy file name to clipboardExpand all lines: tests/test_bigquery.py

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -56,6 +56,13 @@ def test_proxy_no_project(self):
56	56	client = bigquery.Client()
57	57	self._test_proxy(client, should_use_proxy=True)
58	58
	59	+ def test_proxy_with_kwargs(self):
	60	+ env = EnvironmentVarGuard()
	61	+ env.unset('KAGGLE_BQ_USER_JWT')
	62	+ with env:
	63	+ client = bigquery.Client(default_query_job_config=bigquery.QueryJobConfig(maximum_bytes_billed=1e9))
	64	+ self._test_proxy(client, should_use_proxy=True)
	65	+
59	66	def test_project_with_connected_account(self):
60	67	env = EnvironmentVarGuard()
61	68	env.set('KAGGLE_BQ_USER_JWT', 'foobar')

0 commit comments

Comments

0 (0)