fix(@angular/cli): fix leading digit in file names from generate command · feicc/angular-cli@dbfa851 · GitHub

feicc / angular-cli Public

forked from angular/angular-cli

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests 92
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit dbfa851

Browse filesBrowse the repository at this point in the historyBrowse files

RicardoVaranda

authored and

Brocco

committed

fix(@angular/cli): fix leading digit in file names from generate command

1 parent 2b2e8b3 commit dbfa851
Copy full SHA for dbfa851

2 files changed

+14Lines changed: 14 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/@angular/cli/commands
  • generate.ts
• tests/e2e/tests/generate
  • generate-name-error.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/@angular/cli/commands/generate.ts‎

Copy file name to clipboardExpand all lines: packages/@angular/cli/commands/generate.ts

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -78,6 +78,11 @@ export default Command.extend({
78	78	`The \`ng generate ${name}\` command requires a name to be specified.`);
79	79	}
80	80
	81	+ if (/^\d/.test(rawArgs[1])) {
	82	+ SilentError.debugOrThrow('@angular/cli/commands/generate',
	83	+ `The \`ng generate ${name} ${rawArgs[1]}\` file name cannot begin with a digit.`);
	84	+ }
	85	+
81	86	rawArgs[0] = blueprint.name;
82	87	this.registerOptions(blueprint);
83	88	},

Collapse file

‎tests/e2e/tests/generate/generate-name-error.ts‎

Copy file name to clipboard

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,9 @@
	1	+ import {ng} from '../../utils/process';
	2	+ import {expectToFail} from '../../utils/utils';
	3	+
	4	+
	5	+ export default function() {
	6	+ return Promise.resolve()
	7	+ .then(() => expectToFail(() =>
	8	+ ng('generate', 'component', '1my-component')));
	9	+ }

0 commit comments

Comments

0 (0)