FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP feat(fcm): Add Support for AndroidConfigV2 by jonathanedey · Pull Request #3205 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

WIP feat(fcm): Add Support for AndroidConfigV2 - #3205

Draft
jonathanedey wants to merge 6 commits into
mainfrom
je-fcm-v2
ConversationCommits (6)ChecksFiles changed
Draft

WIP feat(fcm): Add Support for AndroidConfigV2#3205
jonathanedey wants to merge 6 commits into
mainfrom
je-fcm-v2

Conversation

jonathanedey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
  • Add androidV2 property to BaseMessage and MulticastMessage interfaces
  • Introduce AndroidConfigV2, AndroidRemoteNotificationConfig, and AndroidBackgroundSyncConfig types
  • Implement validation for androidV2 properties, including nested remoteNotification and backgroundSync exclusivity constraints
  • Enforce mutual exclusivity between legacy android and new androidV2 payload configurations
  • Add unit tests validating androidV2 property serialization, types, and error constraints
  • Export new V2 interfaces

jonathanedey marked this pull request as draft July 6, 2026 17:53
gemini-code-assist Bot reviewed Jul 6, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces the Android V2 configuration (androidV2) for Firebase Cloud Messaging (FCM) payloads, supporting remote notifications and background sync. It includes new TypeScript interfaces, validation logic, and comprehensive unit tests. The feedback suggests refactoring the validateAndroidConfigV2 function to use the existing renameProperties utility for renaming remoteNotification and backgroundSync properties, which would improve consistency and simplify the code.

Comment thread src/messaging/messaging-internal.ts Outdated
jonathanedey changed the title WIP feat(messaging): add support for Android Config V2 WIP feat(fcm): Add Support for AndroidConfigV2 Jul 9, 2026

jonathanedey commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

jonathanedey commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot reviewed Jul 13, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces the new Android Config V2 (androidV2) to the Firebase Admin Messaging API, deprecating the legacy android configuration. It adds several new interfaces and types to support remote notifications and background sync configurations, along with their corresponding validation logic and unit tests. Feedback on the changes highlights that the validateLightSettings helper function contains hardcoded error messages referencing the legacy android.notification path, which will produce misleading error messages when validation fails for androidV2 payloads.

Comment thread src/messaging/messaging-internal.ts Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL