Fix bug that let responsePayloadBytes get set to -1 - #6721
Merged
mrober merged 3 commits intoMar 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 110 files - 76 110 suites - 76 2m 18s ⏱️ - 2m 8s Results for commit 529bb6c. ± Comparison against base commit ec26a52. This pull request removes 1235 and adds 970 tests. Note that renamed tests count towards both.com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull com.google.firebase.firestore.BlobTest ‑ testComparison com.google.firebase.firestore.BlobTest ‑ testEquals com.google.firebase.firestore.BlobTest ‑ testMutableBytes com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals com.google.firebase.firestore.DocumentChangeTest ‑ randomTests com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions … com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Coverage Report 1Affected Products
Test Logs |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Size Report 1Affected Products
Test Logs |
Sorry, something went wrong.
tejasd
approved these changes
Feb 25, 2025
visumickey
approved these changes
Feb 25, 2025
tejasd
approved these changes
Mar 3, 2025
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Fix a bug in `InstrHttpInputStream` that let `NetworkRequestMetric.responsePayloadBytes` get set to -1 in some conditions. While investigating [b/398063523](http://b/398063523), I found that `inputStream.read(...)` can return 0 in some cases, for example, when the byte buffer length is 0. When this happens, it was possible to set `responsePayloadBytes` to -1 because `-1 + 0 = -1`. I didn't just have `bytesRead` initialize to 0 because there is a difference between 0 bytes read, and no read happened. Tested manually by hacking a test app to force this to happen, and by unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in InstrHttpInputStream that let NetworkRequestMetric.responsePayloadBytes get set to -1 in some conditions.
While investigating b/398063523, I found that inputStream.read(...) can return 0 in some cases, for example, when the byte buffer length is 0. When this happens, it was possible to set responsePayloadBytes to -1 because -1 + 0 = -1. I didn't just have bytesRead initialize to 0 because there is a difference between 0 bytes read, and no read happened. Tested manually by hacking a test app to force this to happen, and by unit tests.