FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(firestore): Add ifNull and coalesce expressions by milaGGL · Pull Request #7976 · firebase/firebase-android-sdk · GitHub

feat(firestore): Add ifNull and coalesce expressions - #7976

Merged
milaGGL merged 14 commits into
mainfrom
mila/ifnull-coalesce
Mar 30, 2026
Merged

feat(firestore): Add ifNull and coalesce expressions#7976
milaGGL merged 14 commits into
mainfrom
mila/ifnull-coalesce

Conversation

milaGGL commented Mar 26, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

github-actions Bot commented Mar 26, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

milaGGL commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces support for ifNull and coalesce pipeline expressions in Firestore. The changes include updates to the public API, implementation of these expressions as both static and instance methods in the Expression class, and the addition of integration tests to verify their behavior. A minor typo was identified in the documentation for one of the ifNull overloads.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

yvonnep165 commented Mar 27, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

A minor version bump in the gradle properties file may be required to fix the Metalava SemVer Check error. But maybe merging the latest changes from the main can solve this if someone already did that.

yvonnep165 previously approved these changes Mar 27, 2026

yvonnep165 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

yvonnep165 previously approved these changes Mar 30, 2026
milaGGL merged commit 654f761 into main Mar 30, 2026
28 of 29 checks passed
milaGGL deleted the mila/ifnull-coalesce branch March 30, 2026 21:09
github-actions Bot mentioned this pull request Mar 31, 2026
firebase locked and limited conversation to collaborators Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL