FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(firestore): add support for remaining string expressions by dlarocque · Pull Request #7978 · firebase/firebase-android-sdk · GitHub

/ firebase-android-sdk Public

feat(firestore): add support for remaining string expressions - #7978

Merged
dlarocque merged 11 commits into
mainfrom
dl/string-expressions
Mar 31, 2026
ConversationCommits (11)ChecksFiles changed
Merged

feat(firestore): add support for remaining string expressions#7978
dlarocque merged 11 commits into
mainfrom
dl/string-expressions

Conversation

dlarocque commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Adds support for string expressions ltrim, rtrim, stringRepeat stringReplaceOne stringReplaceAll, stringIndexOf.

Ported from: googleapis/java-firestore#2326

feat(firestore): add support for remaining string expressions
ba5a695 
Adds support for string expressions `ltrim`, `rtrim`, `stringRepeat`
`stringReplaceOne` `stringReplaceAll`, `stringIndexOf`.

Ported from: googleapis/java-firestore#2326

gemini-code-assist Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

github-actions Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

dlarocque commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot reviewed Mar 26, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces several string manipulation functions to the Firestore pipeline API, including ltrim, rtrim, stringRepeat, stringReplaceAll, stringReplaceOne, and stringIndexOf. These functions are added to the Expression class, updated in the public API definition, and supported by new unit tests. The review feedback identifies a duplicate 'substring' key in the FunctionRegistry map that should be removed to avoid redundancy and potential confusion.

Comment thread firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/FunctionRegistry.kt
Comment thread firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt

dlarocque commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot reviewed Mar 26, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces several new string-related pipeline expressions to Firestore, including ltrim, rtrim, stringIndexOf, stringRepeat, stringReplaceOne, and stringReplaceAll. The changes encompass API definition updates, DSL implementations in the Expression class, and comprehensive instrumentation tests for each new function. One minor issue was identified in the CHANGELOG.md where a pull request number in the link text was inconsistent with the actual URL.

Comment thread firebase-firestore/CHANGELOG.md
dlarocque requested a review from milaGGL March 27, 2026 14:45

dlarocque commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot reviewed Mar 27, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces several new string-related pipeline expressions, including ltrim, rtrim, stringIndexOf, stringRepeat, stringReplaceOne, and stringReplaceAll. It also graduates the Pipeline API from Beta status by removing the @beta annotations. Comprehensive unit tests for the new expressions have been added. The review feedback suggests a minor documentation update to ensure consistency with the renaming of the valueToTrim parameter to valuesToTrim.

Comment thread firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
dlarocque requested a review from yvonnep165 March 27, 2026 15:29
milaGGL previously approved these changes Mar 28, 2026
View reviewed changes

milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlarocque requested a review from milaGGL March 31, 2026 14:28
milaGGL approved these changes Mar 31, 2026
View reviewed changes

milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlarocque enabled auto-merge (squash) March 31, 2026 14:51
dlarocque merged commit 1f5b6dd into main Mar 31, 2026
28 of 29 checks passed
dlarocque deleted the dl/string-expressions branch March 31, 2026 15:44
github-actions Bot mentioned this pull request Apr 1, 2026
Open
firebase locked and limited conversation to collaborators Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

milaGGL milaGGL approved these changes
yvonnep165 Awaiting requested review from yvonnep165
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL