FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dataconnect(chore): DataConnectGrpcRPCs.kt: fix wasteful conversion to Struct only used for debug logging by dconeybe · Pull Request #8126 · firebase/firebase-android-sdk · GitHub

/ firebase-android-sdk Public

dataconnect(chore): DataConnectGrpcRPCs.kt: fix wasteful conversion to Struct only used for debug logging - #8126

Merged
dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/DataConnectGrpcRPCsDeferWastefulStructConversion
May 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

dataconnect(chore): DataConnectGrpcRPCs.kt: fix wasteful conversion to Struct only used for debug logging#8126
dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/DataConnectGrpcRPCsDeferWastefulStructConversion

Conversation

dconeybe commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR optimizes the gRPC logging in DataConnectGrpcRPCs.kt by deferring the conversion of request and response objects to Struct protos until they are actually needed for debug logging.

Highlights

  • Deferred Logging Payloads: Refactored logGrpcSending and logGrpcReceived to accept lambdas instead of pre-computed Struct objects, preventing unnecessary computation when debug logging is disabled.
  • Inline Logging Functions: Marked logging helper functions as inline to allow the use of lambda parameters without additional allocation overhead.

Changelog

Modified files
  • CHANGELOG.md: Added an entry for the optimization of debug logging computation.
  • DataConnectGrpcRPCs.kt: Refactored gRPC logging to use inline functions with deferred payload evaluation.

dataconnect(chore): fix wasteful conversion to Struct if debug loggin…
afebb11 
…g was not enabled in DataConnectGrpcRPCs.kt [skip actions]
dconeybe self-assigned this May 9, 2026

gemini-code-assist Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

dconeybe commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist Bot reviewed May 9, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request optimizes debug logging in DataConnectGrpcRPCs.kt by implementing lazy evaluation for gRPC request and response serialization. By updating logGrpcSending and logGrpcReceived to accept lambdas and marking them as inline, the potentially expensive toStructProto() calls are only executed when debug logging is active. Feedback was provided to replace a placeholder PR number in the CHANGELOG.md file.

Comment thread firebase-dataconnect/CHANGELOG.md Outdated

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

dconeybe marked this pull request as ready for review May 9, 2026 18:33
dconeybe merged commit 7fdcceb into main May 11, 2026
52 of 54 checks passed
dconeybe deleted the dconeybe/dataconnect/DataConnectGrpcRPCsDeferWastefulStructConversion branch May 11, 2026 17:27
firebase locked and limited conversation to collaborators Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

aashishpatil-g aashishpatil-g approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

dconeybe

Labels

api: dataconnect main-merge-ack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL