[AppCheck] Require reCAPTCHA site key as an initialization parameter - #8457
[AppCheck] Require reCAPTCHA site key as an initialization parameter #8457rlazo merged 6 commits into
Conversation
Sorry, something went wrong.
Introduced `RecaptchaAppCheckProviderFactory.getInstance(String)` to allow passing the reCAPTCHA site key directly. Deprecated the site key methods in FirebaseOptions in favor of this new approach and updated the factory to support singleton provider initialization when using an explicit site key. Internal b/535703681
Removed `getRecaptchaSiteKey` from `FirebaseOptions` and deprecated `RecaptchaAppCheckProviderFactory.getInstance()` methods. Site keys must now be provided explicitly via `RecaptchaAppCheckProviderFactory.getInstance(String)`.
|
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Sorry, something went wrong.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Sorry, something went wrong.
|
/gemini review |
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request deprecates the reCAPTCHA site key configuration in FirebaseOptions and moves it directly to RecaptchaAppCheckProviderFactory.getInstance(String). The feedback suggests removing the stateful caching of the provider and double-checked locking in RecaptchaAppCheckProviderFactory to avoid issues in multi-app environments. Additionally, it recommends updating the corresponding tests to verify delegation on every call and removing obsolete @SuppressWarnings("deprecation") annotations in FirebaseOptionsTest.
Sorry, something went wrong.
|
As mentioned in the description, it's expected that metalava will complain, but it's OK to ignore and not mark it as a major version bump. |
Sorry, something went wrong.
Removed getRecaptchaSiteKey from FirebaseOptions and deprecated RecaptchaAppCheckProviderFactory.getInstance() methods. Site keys must now be provided explicitly via
RecaptchaAppCheckProviderFactory.getInstance(String).
While the API existed, the support from the backend didn't. Because of it we are marking the change as non-breaking.