FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for testing in-app messages in SwiftUI previews by christibbs · Pull Request #8351 · firebase/firebase-ios-sdk · GitHub

/ firebase-ios-sdk Public

Add support for testing in-app messages in SwiftUI previews - #8351

Merged
christibbs merged 23 commits into
masterfrom
fiam-swiftui-previews
Jul 16, 2021
ConversationCommits (23)ChecksFiles changed
Merged

Add support for testing in-app messages in SwiftUI previews#8351
christibbs merged 23 commits into
masterfrom
fiam-swiftui-previews

Conversation

christibbs commented Jul 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

In core FIAM SDK: Opens up initializers for image subclasses

  • See changes in FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h

In core FIAM UI test project, refactor to use open message initializers

  • See changes in test files
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/BannerMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ImageOnlyMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ModalMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/CardMessageViewController.swift

In FIAM SwiftUI SDK: Adds preview helper methods to create canned in-app messages

  • See changes in new file FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift

In FIAM SwiftUI integration test project: Updates project to use SwiftUI preview helpers

  • See changes in new file FirebaseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/Shared/ModalInAppMessageView.swift

christibbs added 10 commits June 23, 2021 18:58
google-cla Bot added the cla: yes label Jul 8, 2021

google-oss-bot commented Jul 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Report

Affected SDKs

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    SDK overall coverage changed from 45.31% (6444730) to 46.08% (2d909b5) by +0.77%.

    Filename Base (6444730) Head (2d909b5) Diff
    FIRIAMDisplayExecutor.m 68.73% 68.65% -0.08%
    FIRInAppMessagingRenderingDataClasses.m 62.69% 88.83% +26.15%

Test Logs

ryanwilson reviewed Jul 12, 2021
View reviewed changes
Comment thread FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h Outdated
Comment thread FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h
Comment thread FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h
Comment thread FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h Outdated
Comment thread FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h Outdated
Comment thread FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift Outdated
Comment thread FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift Outdated
Comment thread FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift Outdated
Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj
Comment thread ...ng/Tests/Integration/DefaultUITestApp/InAppMessagingDisplay-Sample.xcodeproj/project.pbxproj Outdated

christibbs commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

@ryanwilson Resolved all open items, PTAL!

ryanwilson approved these changes Jul 16, 2021
View reviewed changes

ryanwilson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a couple small things with the xcproject but otherwise LGTM. Thanks!

Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj
Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj Outdated
Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj Outdated
Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj Outdated
Comment thread ...baseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/FIAMSwiftUI.xcodeproj/project.pbxproj Outdated
christibbs merged commit 6e3f659 into master Jul 16, 2021
christibbs deleted the fiam-swiftui-previews branch July 16, 2021 20:04
This was referenced Jul 17, 2021
Merged
Open
firebase locked and limited conversation to collaborators Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

ryanwilson ryanwilson approved these changes
eldhosembabu Awaiting requested review from eldhosembabu

Assignees

No one assigned

Labels

api: inappmessaging Firebase In App Messaging cla: yes public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL