Add OOB flow to reset email when updateEmail is used. - #3096
Merged
ssbushi merged 18 commits intoFeb 17, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ssbushi
commented
Jan 29, 2021
Comment thread
src/emulator/auth/handlers.ts
Outdated
ssbushi
commented
Jan 29, 2021
Comment thread
src/emulator/auth/operations.ts
Outdated
ssbushi
commented
Jan 29, 2021
Comment thread
src/emulator/auth/operations.ts
Outdated
yuchenshi
requested changes
Jan 29, 2021
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
yuchenshi
previously requested changes
Feb 10, 2021
yuchenshi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
General approach LGTM. See blocking comments below and tests please.
Sorry, something went wrong.
Comment thread
src/emulator/auth/handlers.ts
Outdated
Comment thread
src/emulator/auth/handlers.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/state.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
yuchenshi
reviewed
Feb 16, 2021
Comment thread
src/emulator/auth/operations.ts
Outdated
ssbushi
marked this pull request as ready for review
February 17, 2021 17:41
yuchenshi
approved these changes
Feb 17, 2021
yuchenshi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with nits
Sorry, something went wrong.
Comment thread
src/emulator/auth/operations.ts
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
Comment thread
src/emulator/auth/operations.ts
Outdated
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
This was referenced Mar 12, 2021
Closed
Closed
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3070. Tests are pending. Drafting a PR to clarify a few things.
Scenarios Tested
Manually tested creating an account, updating email and using the oobLink to reset email.
Sample Commands
await firebase.auth().createUserWithEmailAndPassword('test@email.com', 'testing');
await firebase.auth().currentUser?.updateEmail('test1@email.com');
HTTP GET http://localhost:9099/emulator/v1/projects/project-test/oobCodes