Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tonybaroneee
approved these changes
Apr 2, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* remove plist, update netmask * rm jsonschema * upgrade sinon chai * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As far as I can tell, thanks to this comment I think plist is unused. It looks like it was added and not ever used: #1621
While I'm here, npm audit fix took care of netmask's issue.
Also, 'cause deps:
Scenarios Tested
The appdistribution:distribute command still works (though I have no real test data to run through it). AFAIK no code calls plist that we have.