feat: display meaningful error msg when cannot determine target - #6594
Merged
9kubczas4 merged 14 commits intoJul 16, 2024
Merged
feat: display meaningful error msg when cannot determine target#65949kubczas4 merged 14 commits into
9kubczas4 merged 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.
@@ Coverage Diff @@
## master #6594 +/- ##
==========================================
+ Coverage 54.61% 54.79% +0.18%
==========================================
Files 356 358 +2
Lines 24892 25015 +123
Branches 5136 5157 +21
==========================================
+ Hits 13594 13708 +114
- Misses 10066 10072 +6
- Partials 1232 1235 +3 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
jamesdaniels
suggested changes
Dec 8, 2023
Comment thread
src/frameworks/angular/utils.ts
Outdated
Comment thread
src/frameworks/angular/utils.ts
Outdated
Comment thread
src/frameworks/angular/utils.ts
Copy link
Copy Markdown
Contributor
|
Few small things, thanks |
Sorry, something went wrong.
leoortizz
reviewed
Apr 1, 2024
Comment thread
src/frameworks/angular/utils.ts
Outdated
jamesdaniels
approved these changes
Jul 15, 2024
9kubczas4
enabled auto-merge (squash)
July 16, 2024 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display a meaningful error message when the cannot determine the target.
It would be helpful in scenarios when the user changed default configuration names, for example, production to live.
This change allows us to understand better what needs to be done by the developer to fix this issue.
Previous error message: Error: Configuration 'production' is not set in the workspace.
Current error message: Unable to determine the application to deploy, specify a target via the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable.
Related to #6138.
Scenarios Tested