FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FAH bugfixes by inlined · Pull Request #6754 · firebase/firebase-tools · GitHub

/ firebase-tools Public

FAH bugfixes - #6754

Merged
inlined merged 2 commits into
masterfrom
inlined.build-id-fix
Feb 9, 2024
ConversationCommits (2)ChecksFiles changed
Merged

FAH bugfixes#6754
inlined merged 2 commits into
masterfrom
inlined.build-id-fix

Conversation

inlined commented Feb 8, 2024

Copy link
Copy Markdown
Member
  1. Fixes issue where the --branch param on builds:create is ignored
  2. Fixes issue where the build ID uses day of week instead of day of month

inlined requested a review from bkendall February 8, 2024 00:29

codecov-commenter commented Feb 8, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.31%. Comparing base (a4abfa5) to head (40a545d).
⚠️ Report is 1447 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6754   +/-   ##
=======================================
  Coverage   54.31%   54.31%           
=======================================
  Files         349      349           
  Lines       24283    24283           
  Branches     5021     5021           
=======================================
  Hits        13190    13190           
  Misses       9888     9888           
  Partials     1205     1205

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bkendall approved these changes Feb 9, 2024
View reviewed changes
Comment thread src/commands/apphosting-builds-create.ts
(options.buildId as string) ||
(await apphosting.getNextRolloutId(projectId, location, backendId));
const branch = options.branch as string;
const branch = (options.branch as string | undefined) ?? "main";

bkendall Feb 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A really neat improvement to this would be to see if they have a RolloutPolicy and pull the "default" branch from there. But that can come later.

inlined Feb 9, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

File a bug and assign it to me. I agree that would be much better, but IIRC rollouts is still an "internal tool" that hasn't gone through API review.

inlined merged commit 0d975e3 into master Feb 9, 2024
inlined deleted the inlined.build-id-fix branch February 9, 2024 00:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bkendall bkendall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL