Pass down functions.ignore values in firebase.json to functions emulator - #7414
Merged
joehan merged 3 commits intoJul 8, 2024
Merged
Pass down functions.ignore values in firebase.json to functions emulator#7414joehan merged 3 commits into
joehan merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Whoops, apparently I forgot to checkout my new branch and committed the changes to the master branch of my fork, is that okay? |
Sorry, something went wrong.
joehan
approved these changes
Jul 8, 2024
joehan
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the contribution! Lgtm, but could you add an entry to changelog.md for this change?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@joehan do you mean changelog.md in the root directory? is it supposed to be empty? edit: ah is it reset on every release? edit2: done |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass down functions.ignore values in firebase.json to functions emulator so that supposedly ignored directories/files will not trigger reload.