FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: handle paths with spaces in getGlobalEsbuildVersion function by dxdc · Pull Request #7571 · firebase/firebase-tools · GitHub

/ firebase-tools Public

fix: handle paths with spaces in getGlobalEsbuildVersion function - #7571

Merged
leoortizz merged 7 commits into
firebase:masterfrom
dxdc:dxdc-next-patch-1
Sep 18, 2024
ConversationCommits (7)ChecksFiles changed
Merged

fix: handle paths with spaces in getGlobalEsbuildVersion function#7571
leoortizz merged 7 commits into
firebase:masterfrom
dxdc:dxdc-next-patch-1

Conversation

dxdc commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Description

  • Wrapped the binPath in double quotes to correctly handle paths containing spaces.
  • Ensured execSync properly executes the command when the binary path includes spaces.

Scenarios Tested

Sample Commands

google-cla Bot commented Aug 20, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

joehan commented Aug 20, 2024

Copy link
Copy Markdown
Member

Looks like there are test failures for this, please fix.

dxdc commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

done

jamesdaniels commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

@leoortizz PTAL

codecov-commenter commented Sep 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (18e3189) to head (ca51c59).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7571      +/-   ##
==========================================
- Coverage   56.91%   56.90%   -0.01%     
==========================================
  Files         396      396              
  Lines       27599    27599              
  Branches     5692     5692              
==========================================
- Hits        15708    15706       -2     
- Misses      11723    11725       +2     
  Partials      168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chalosalvador approved these changes Sep 13, 2024
View reviewed changes

chalosalvador left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

leoortizz merged commit 6bd497d into firebase:master Sep 18, 2024
leoortizz added a commit that referenced this pull request Sep 18, 2024
add changelog for #7571
b2fc164
leoortizz added a commit that referenced this pull request Sep 18, 2024
add changelog for #7571
9a44161
leoortizz mentioned this pull request Sep 18, 2024
Merged
joehan added a commit that referenced this pull request Sep 18, 2024
add changelog for #7571 (#7681)
211c0af 
* add changelog for #7571

* Update CHANGELOG.md

---------

Co-authored-by: joehan <joehanley@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chalosalvador chalosalvador approved these changes
joehan joehan approved these changes

Assignees

No one assigned

Labels

integration: web frameworks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL