fix: identify dependencies that might require the --no-tree-shake-icons flag - #7724
Merged
emwp merged 15 commits intoOct 11, 2024
Merged
fix: identify dependencies that might require the --no-tree-shake-icons flag#7724emwp merged 15 commits into
emwp merged 15 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…flutter-tree-shake
…-tools into fix/flutter-tree-shake
leoortizz
requested changes
Sep 24, 2024
Comment thread
src/frameworks/flutter/index.ts
Outdated
Comment thread
src/frameworks/flutter/utils.ts
Outdated
Comment thread
src/frameworks/flutter/utils.ts
Outdated
leoortizz
reviewed
Sep 24, 2024
Comment thread
src/frameworks/flutter/utils.ts
leoortizz
reviewed
Oct 1, 2024
Comment thread
src/frameworks/flutter/utils.ts
jamesdaniels
approved these changes
Oct 8, 2024
jamesdaniels
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks. LGTM. Let's add changelog, i'll let @leoortizz shepherd the final approval and merge
Sorry, something went wrong.
leoortizz
requested changes
Oct 8, 2024
Comment thread
src/frameworks/flutter/index.ts
leoortizz
approved these changes
Oct 8, 2024
leoortizz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Comment thread
CHANGELOG.md
Outdated
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
…flutter-tree-shake
leoortizz
requested changes
Oct 10, 2024
Comment thread
CHANGELOG.md
Outdated
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
emwp
enabled auto-merge (squash)
October 11, 2024 01:55
leoortizz
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to this issue: #6197
Trying to identify dependencies that might require the --no-tree-shake-icons build flag.
Unfortunately can not allow users to pass arbitrary/custom flags when running the deploy function, so tried to identify dependencies that are likely to require the flag to build.
Scenarios Tested
fixes #6197