chore: update dependencies for firebase functions template - #7809
Merged
emwp merged 8 commits intoOct 16, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…e/update-functions-template-dependencies
leoortizz
reviewed
Oct 11, 2024
Comment thread
templates/extensions/javascript/package.lint.json
Comment on lines
+6
to
+7
| "firebase-admin": "^12.6.0", | ||
| "firebase-functions": "^6.0.1" |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
does this impact web frameworks too? What happens if we keep it as before?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@leoortizz Upgraded the extensions as well since last time an upgrade like this was done, it was requested the extensions to be done as well, see:
#7084 (review)
Can be removed if you think it's better!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is not related to web frameworks, this is for ext:dev:init. We should keep these changes to templates/extensions
Sorry, something went wrong.
…e/update-functions-template-dependencies
emwp
enabled auto-merge (squash)
October 11, 2024 22:20
joehan
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the firebase-functions and firebase-admin dependencies for the firebase functions init template.
fixes #7385
Scenarios Tested
Initializing a new project with init functions and deploy commands:
Screenshot