fix: enable Secret Manager when function includes secrets - #8528
Merged
taeold merged 3 commits intoMay 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the issue of ensuring the Secret Manager API is enabled during function deployment when secrets are present. Key changes include adding the secretManagerOrigin import, refactoring API enablement logic into the new ensureAllRequiredAPIsEnabled function, and adding corresponding tests for the new behavior.
- Add secretManagerOrigin import and update API enablement logic.
- Extract API enablement into ensureAllRequiredAPIsEnabled, including secret handling for secrets.
- Extend test coverage for the new API enablement function.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/deploy/functions/prepare.ts | Refactored API enablement logic and ensured Secret Manager API is enabled when secrets are used. |
| src/deploy/functions/prepare.spec.ts | Added tests to validate the new ensureAllRequiredAPIsEnabled function. |
Sorry, something went wrong.
Comment thread
src/deploy/functions/prepare.ts
Outdated
colerogers
approved these changes
May 9, 2025
taeold
enabled auto-merge (squash)
May 9, 2025 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When secret is included in any function that's being deploy, we'll ensure that the Secret Manager API is enabled before proceeding with the deploy.
Fixes #5307