Fix an issue where updating a Cloud Function that retires would add incorrect fields to the updateMask - #8560
Merged
colerogers merged 3 commits intoMay 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ssing between retries
taeold
approved these changes
May 13, 2025
Comment thread
CHANGELOG.md
Outdated
Co-authored-by: Daniel Lee <danielylee@google.com>
colerogers
enabled auto-merge (squash)
May 13, 2025 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a deployment we add buildEnvironmentVariables to the Cloud Function on Creates/Updates. If the Update operation fails, then we'll retry using the same Cloud Function reference. This reference contains the new fields which the field mask on the retry to contain all buildEnvironmentVariables.$VAR. These are not recognized on the Cloud Functions API and will return a 400 - The updateMask field contains fields not existing in CloudFunction resource.