FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expose firebase init aitools command by taeold · Pull Request #8949 · firebase/firebase-tools · GitHub

/ firebase-tools Public

Expose firebase init aitools command - #8949

Merged
joehan merged 9 commits into
masterfrom
dl-ai-init
Aug 6, 2025
ConversationCommits (9)ChecksFiles changed
Merged

Expose firebase init aitools command#8949
joehan merged 9 commits into
masterfrom
dl-ai-init

Conversation

taeold commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Exposes firebase init aitools command with few bug fixes (fixes #8946)

Changes

  • Claude configuration updates:

    • .claude/settings.local.json → .mcp.json (follows new MCP standard)
    • CLAUDE.local.md → CLAUDE.md (follows new memory standard)

  • Command exposure:

    • Adds aitools to init features (hidden from menu)
    • Registers in command choices array

  • Minor fixes:

    • Fixes markdown formatting in FIREBASE.md

Context

Fixes compatibility issue where Claude Code 1.0.69+ doesn't recognize mcpServers in settings.local.json.

References: MCP docs, Memory docs

taeold added 3 commits August 6, 2025 13:31
fix(init): update Claude AIToolModule for latest Claude Code compatib…
881be4c 
…ility

Updates MCP server configuration to use .mcp.json instead of deprecated .claude/settings.local.json.
Updates to use CLAUDE.md instead of deprecated CLAUDE.local.md.
Fixes compatibility with Claude Code 1.0.69+.
feat(init): expose aitools command
2cf27d9 
Adds firebase init:aitools to available commands.
Fixes formatting in FIREBASE.md prompt file.
fix(init): register aitools in command choices
963e2b7 
Adds aitools to init command choices array so it's recognized as valid feature.
Marked as hidden to keep it from public menu while in development.
gemini-code-assist Bot reviewed Aug 6, 2025
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the integration of AI coding assistants, specifically Claude, with Firebase projects. It addresses a critical compatibility issue with newer Claude Code versions by updating configuration file paths and introduces a new aitools command to streamline the setup process for these tools within a Firebase project.

Highlights

  • Compatibility Update: I've updated the Claude AIToolModule to ensure compatibility with Claude Code 1.0.69+ by adjusting the expected configuration file paths.
  • New Command Exposure: I've exposed the firebase init aitools command, which allows users to configure AI coding assistants to work with their Firebase project. This command is hidden from the default interactive menu but can be invoked directly.
  • Configuration File Migration: The Claude configuration files have been migrated from .claude/settings.local.json to .mcp.json and CLAUDE.local.md to CLAUDE.md to align with the new MCP and memory standards for Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist Bot reviewed Aug 6, 2025
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request updates the Claude AIToolModule for compatibility with recent changes and exposes the firebase init aitools command. The changes are well-contained and correctly implement the desired functionality. I've added one suggestion to improve type safety in claude.ts by replacing an any type with a more specific one. Overall, the changes look good.

Comment thread src/init/features/aitools/claude.ts Outdated
taeold changed the title Fix Claude AIToolModule compatibility and expose aitools command Expose firebase init aitools command Aug 6, 2025
Update src/init/features/aitools/claude.ts
d1a7c30 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
taeold requested a review from joehan August 6, 2025 21:20
joehan enabled auto-merge (squash) August 6, 2025 22:21
joehan merged commit 1d3e49a into master Aug 6, 2025
48 checks passed
joehan deleted the dl-ai-init branch August 6, 2025 22:32
github-project-automation Bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joehan joehan approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MCP] Claude Code MCP support requires .mcp.json

2 participants

Back | FazBrowse Home | New Git URL