| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Summary of ChangesHello @NickChittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the firestore:databases:create command by introducing new parameters that provide granular control over Firestore database configurations. Users can now specify data access modes (Firestore Native or MongoDB compatible) and real-time update settings directly via the CLI, particularly benefiting Enterprise edition databases with more tailored setup options. The changes ensure proper validation, defaulting, and API integration for these new features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
This pull request adds support for DataAccessModes and RealtimeUpdates modes when creating a Firestore database. The changes are well-implemented across the command, API types, and API client. My review focuses on improving code quality by reducing duplication in both the command implementation and its tests, and enhancing the consistency of the new command-line options.
Sorry, something went wrong.
There was a problem hiding this comment.
This mostly looks good to me. The comments on how we handle these flags for standard edition dbs are blocking, the type improvements are optional nits.
Also, please add a CHANGELOG entry
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Adding support for the firestore_data_access_mode, mongodb_compatible_data_access_mode, and realtime_updates_mode Database Creation Parameters.
Scenarios Tested
Creating databases with all combinations of ENABLE/DISABLED for firestoreDataAccess and mongodbCompatibleDataAccess.
realtimeUpdates can be ENABLED/DISABLED with firestoreDataAccess.
realtimeUpdates correctly fails when trying to enable with mongodbCompatibleDataAccess
Sample Commands
firebase firestore:databases:create my-database-id --location=nam5 --edition=enterprise --project=my-project --firestore-data-access=ENABLED
firebase firestore:databases:create my-database-id --location=nam5 --edition=enterprise --project=my-project --firestore-data-access=ENABLED --realtime-updates=DISABLED
firebase firestore:databases:create my-database-id --location=nam5 --edition=enterprise --project=my-project --mongodb-compatible-data-access=ENABLED