FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add new line warning to README by chinedufn · Pull Request #115 · googleapis/php-jwt · GitHub

Repository navigation

Add new line warning to README - #115

Merged
bshaffer merged 1 commit into
googleapis:masterfrom
tailwind:newline-warning
Jun 22, 2017
Merged

bshaffer merged 1 commit into
googleapis:masterfrom
tailwind:newline-warning

Conversation

Copy link
Copy Markdown

Quickly addresses #109, but a better solution would be to warn the user if they're using RSA and we don't see any new lines in their private key.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 7, 2016

Copy link
Copy Markdown
Collaborator

@chinedufn you need to sign the CLA before we can merge this

Copy link
Copy Markdown
Author

cool - signed

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 22, 2017
bshaffer merged commit 8becb3b into googleapis:master Jun 22, 2017
chinedufn deleted the newline-warning branch June 22, 2017 04:04
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
bshaffer pushed a commit that referenced this pull request Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL