FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes Objective-C objects memory leaks by zhongwuzw · Pull Request #14326 · flutter-team-archive/engine · GitHub

This repository was archived by the owner on Feb 25, 2025. It is now read-only.
/ engine Public archive

Fixes Objective-C objects memory leaks - #14326

Merged
cbracken merged 6 commits into
flutter-team-archive:masterfrom
zhongwuzw:fix_platform_oc_leaks
Dec 18, 2019
ConversationCommits (6)ChecksFiles changed
Merged

Fixes Objective-C objects memory leaks#14326
cbracken merged 6 commits into
flutter-team-archive:masterfrom
zhongwuzw:fix_platform_oc_leaks

Conversation

zhongwuzw commented Dec 11, 2019 •
edited by cyanglaz
Loading

Copy link
Copy Markdown
Contributor

Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750

auto-assign Bot requested a review from franciscojma86 December 11, 2019 10:12
zhongwuzw mentioned this pull request Dec 11, 2019
Closed
chinmaygarde approved these changes Dec 11, 2019
View reviewed changes
Comment thread shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm Outdated
Comment thread shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm Outdated
Comment thread shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
auto contentsScale = flutter_view_.get().layer.contentsScale;
fml::scoped_nsobject<FlutterOverlayView> overlay_view(
[[[FlutterOverlayView alloc] initWithContentsScale:contentsScale] retain]);
[[FlutterOverlayView alloc] initWithContentsScale:contentsScale]);

chinmaygarde Dec 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch!

zhongwuzw commented Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

@chinmaygarde Done.

cbracken approved these changes Dec 16, 2019
View reviewed changes

cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cbracken commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Waiting for the tree to go green before we merge.

cbracken merged commit 9c1bd8a into flutter-team-archive:master Dec 18, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
b88181f 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
e87c517 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
a4ba3fe 
…engine#14326)
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
bee9b03 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
3c47cc8 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
5d10e6f 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
7a86814 
…engine#14326)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
f06b992 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
46a738a 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
a1d5c51 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
cae129a 
…engine#14326)
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
2fb4f0f 
…engine#14326)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
8cda8b9 
…engine#14326)
engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
a215b20 
…engine#14326)
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
ed0e2d3 
…engine#14326)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
514c226 
…engine#14326)
This was referenced Dec 19, 2019
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/…
aa86bff 
…engine#14326)
chingjun pushed a commit to flutter/flutter that referenced this pull request Dec 19, 2019
Roll engine 1e1f371..0f90e65 (14 commits) (#47429)
4af66e3 
* 988b8f1 Fix FontLoader does not remove the cache in web engine (flutter-team-archive/engine#14536)

* 0aacac7 Roll src/third_party/skia 21df075cab00..e6a2ad81ab40 (1 commits) (flutter-team-archive/engine#14552)

* 417dd7e Roll fuchsia/sdk/core/mac-amd64 from esDH2... to NHgyx... (flutter-team-archive/engine#14554)

* f2e841d [Web] Fix pointer binding  (flutter-team-archive/engine#14378)

* 105eb66 Roll src/third_party/skia e6a2ad81ab40..8fec4140f614 (17 commits) (flutter-team-archive/engine#14557)

* 1ecfdcb [web] Calculate align offset for each paragraph line (LineMetrics.left) (flutter-team-archive/engine#14537)

* dda3619 Roll src/third_party/dart 270966b16044..171059d27689 (19 commits) (flutter-team-archive/engine#14558)

* 9c1bd8a Fixes Objective-C objects memory leaks (flutter-team-archive/engine#14326)

* f2dbeb8 Reland Wire up Opacity on Fuchsia (flutter-team-archive/engine#14559)

* 2f536e5 Roll fuchsia/sdk/core/linux-amd64 from jsuQq... to VdBKA... (flutter-team-archive/engine#14560)

* 4312d37 Revert "[fuchsia] Add diagnostics directory to the set of remote dirs (#14470)" (flutter-team-archive/engine#14566)

* 5c77ea1 Roll src/third_party/skia 8fec4140f614..9e0afb791ac2 (4 commits) (flutter-team-archive/engine#14563)

* a09ff7c Roll src/third_party/dart 171059d27689..aa6709974dea (11 commits) (flutter-team-archive/engine#14567)

* 0f90e65 Revert "[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537)" (flutter-team-archive/engine#14569)
shorben07 mentioned this pull request Jan 9, 2020
Closed
cyanglaz mentioned this pull request Jan 22, 2020
Closed
Partizann pushed a commit to Partizann/engine that referenced this pull request Mar 10, 2020
Fixes Objective-C objects memory leaks (flutter-team-archive#14326)
91c813b 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Fixes Objective-C objects memory leaks (flutter-team-archive#14326)
a11abf1 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
cyanglaz mentioned this pull request Apr 27, 2020
Closed
liyuqian added perf: memory Performance issues related to memory severe: performance Relates to speed or footprint issues. labels Jul 28, 2020

joaovirgili commented Aug 14, 2020

Copy link
Copy Markdown

is this already available on stable channel?

mafreud mentioned this pull request Oct 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

franciscojma86 Awaiting requested review from franciscojma86
2 more reviewers
chinmaygarde chinmaygarde approved these changes
cbracken cbracken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes perf: memory Performance issues related to memory severe: performance Relates to speed or footprint issues.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL