Commit c6f44e1
t9813: avoid using pipes
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Acked-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>1 parent c7cf956 commit c6f44e1
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -118,12 +118,12 @@ test_expect_success 'not preserving user with mixed authorship' ' | |||
| 118 | 118 | make_change_by_user usernamefile3 Derek derek@example.com && | |
| 119 | 119 | P4EDITOR=cat P4USER=alice P4PASSWD=secret && | |
| 120 | 120 | export P4EDITOR P4USER P4PASSWD && | |
| 121 | - git p4 commit |\ | ||
| 122 | - grep "git author derek@example.com does not match" && | ||
| 121 | + git p4 commit >actual && | ||
| 122 | + grep "git author derek@example.com does not match" actual && | ||
| 123 | 123 | ||
| 124 | 124 | make_change_by_user usernamefile3 Charlie charlie@example.com && | |
| 125 | - git p4 commit |\ | ||
| 126 | - grep "git author charlie@example.com does not match" && | ||
| 125 | + git p4 commit >actual && | ||
| 126 | + grep "git author charlie@example.com does not match" actual && | ||
| 127 | 127 | ||
| 128 | 128 | make_change_by_user usernamefile3 alice alice@example.com && | |
| 129 | 129 | git p4 commit >actual && | |
0 commit comments