FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Committing a branch without new commits generates extra mail · Issue #136 · git-commit-notifier/git-commit-notifier · GitHub

Repository navigation

Committing a branch without new commits generates extra mail #136

Closed

Description

Currently, we populate a set with git rev-parse --not --branches, delete the new branch from the set, add the current branch into the set, and gather the commits with git rev-list #{set}, essentially.

If you do something like
git checkout master
git branch foo; git push origin foo

You'll get notified for all commits on master that aren't on other branches, since foo and master share the same hash (which gets removed from the set).

Easy fix for this is to use an Array instead of a Set. There are some other corner cases if we push more than one branch at a time, but I'll save that for another ticket.

Activity

  1. added a commit that references this issue on Jun 14, 2012
  2. added a commit that references this issue on Jun 14, 2012
  3. added a commit that references this issue on Jun 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL