"Add Lightweight Tag" uses non-canonical sender address #173
Description
After git tag foo && git push --tags the commit message produced by git-commit-notifier got stuck in mailman's moderation queue.
Closer inspection revealed that it was sent with a From: mg@fridge.pov.lt header instead of the expected From: Marius Gedminas <marius@pov.lt>.
If git-commit-notifier doesn't have enough metadata (this is a lightweight tag after all) and has to fall back to the Unix user account who ran the post-receive hook, it could at least use that user's ~/.gitconfig to get appropriate user.name and user.email.
Activity
akzhan commented on Feb 25, 2013
Interesting. Will review, but pull requests are also very apprepriated ;)
mgedmin commented on Feb 26, 2013
Pull requests would be easier if I knew Ruby :-)
(I actually started a branch for adding support for nicer URLs that make use of gitweb's pathinfo feature, then stopped when I realized I've no idea how to run the test suite.)
akzhan commented on Feb 26, 2013
@mgedmin It's simple to test it in real life.
Install required dependencies:
Run for last commit in TEST_REPO.