Pushing a new branch resulted in Iconv::IllegalSequence in diff_to_html #188
Description
$ git push origin HEAD:refs/heads/wip/jeremyhu-blocked X11 forwarding request failed on channel 0 Total 0 (delta 0), reused 0 (delta 0) remote: Sending mail... remote: /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:541:in `iconv': "?"];\n+ [playB"... (Iconv::IllegalSequence) remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:541:in `diff_for_commit' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:713:in `diff_for_branch' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:712:in `each' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:712:in `diff_for_branch' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/diff_to_html.rb:761:in `diff_between_revisions' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/commit_hook.rb:244:in `run' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/executor.rb:29:in `run!' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/executor.rb:27:in `each_line' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/lib/git_commit_notifier/executor.rb:27:in `run!' remote: from /path/to/Gems/1.8/gems/git-commit-notifier-0.11.11/bin/git-commit-notifier:15 remote: from /path/to/Gems/1.8/bin/git-commit-notifier:19:in `load' remote: from /path/to/Gems/1.8/bin/git-commit-notifier:19 To ssh://my.git.server/path/to/repo.git * [new branch] HEAD -> wip/jeremyhu-blocked
Activity
akzhan commented on Jun 8, 2013
Looks like your source code is not UTF-8 compatible... Will look for.
akzhan commented on Jun 8, 2013
Strange that @ic = Iconv.new('UTF-8', 'UTF-8//IGNORE') doesn't helps you.
Please try to update ruby to 1.9 or 2.0 (and reinstall git-commit-notifier) if possible.
jeremyhu commented on Jun 9, 2013
I did a check of all the files in the repo and the only ones that don't check out as valid UTF-8 are UTF-16, png, icns, or binary nib.
jdberry commented on Jun 14, 2013
Hi Jeremy. I did some work on problems with UTF-8 encoding in this project back in Dec '11, but I think some of that may have been broken by more recent changes... I recently saw some commit messages come through my repo with broken UTF-8 sequences.
akzhan commented on Nov 8, 2013
Temporary solution is to use Ruby 1.9 or above.