FazBrowse GitHub Viewer
|
Trending
|
URL:
|
Home
Tools:
[Download Repo ZIP]
[View Raw Code]
[Original HTTPS Page]
codeql/python/ql/src/analysis/Consistency.ql at codeql-cli/v2.15.3 · github/codeql · GitHub
Uh oh!
There was an error while loading.
Please reload this page
.
github
/
codeql
Public
Notifications
You must be signed in to change notification settings
Fork
2.1k
Star
10k
Code
Issues
997
Pull requests
463
Discussions
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights
Expand file tree
Breadcrumbs
codeql
/
python
/
ql
/
src
/
analysis
/
Consistency.ql
Copy path
More file actions
More file actions
Latest commit
History
History
History
292 lines (272 loc) · 9.88 KB
Breadcrumbs
codeql
/
python
/
ql
/
src
/
analysis
/
Consistency.ql
Copy path
File metadata and controls
292 lines (272 loc) · 9.88 KB
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
/**
* @name Consistency check
* @description General consistency check to be run on any and all code. Should never produce any results.
* @id py/consistency-check
*/
import
python
import
analysis.DefinitionTracking
predicate
uniqueness_error
(
int
number
,
string
what
,
string
problem
)
{
what
in
[
"toString"
,
"getLocation"
,
"getNode"
,
"getDefinition"
,
"getEntryNode"
,
"getOrigin"
,
"getAnInferredType"
]
and
(
number
=
0
and
problem
=
"no results for "
+
what
+
"()"
or
number
in
[
2
..
10
]
and
problem
=
number
.
toString
(
)
+
" results for "
+
what
+
"()"
)
}
predicate
ast_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
AstNode
a
|
clsname
=
a
.
getAQlClass
(
)
|
uniqueness_error
(
count
(
a
.
toString
(
)
)
,
"toString"
,
problem
)
and
what
=
"at "
+
a
.
getLocation
(
)
.
toString
(
)
or
uniqueness_error
(
strictcount
(
a
.
getLocation
(
)
)
,
"getLocation"
,
problem
)
and
what
=
a
.
getLocation
(
)
.
toString
(
)
or
not
exists
(
a
.
getLocation
(
)
)
and
not
a
.
(
Module
)
.
isPackage
(
)
and
problem
=
"no location"
and
what
=
a
.
toString
(
)
)
}
predicate
location_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
Location
l
|
clsname
=
l
.
getAQlClass
(
)
|
uniqueness_error
(
count
(
l
.
toString
(
)
)
,
"toString"
,
problem
)
and
what
=
"at "
+
l
.
toString
(
)
or
not
exists
(
l
.
toString
(
)
)
and
problem
=
"no toString"
and
(
exists
(
AstNode
thing
|
thing
.
getLocation
(
)
=
l
|
what
=
"a location of a "
+
thing
.
getAQlClass
(
)
)
or
not
exists
(
AstNode
thing
|
thing
.
getLocation
(
)
=
l
)
and
what
=
"a location"
)
or
l
.
getEndLine
(
)
<
l
.
getStartLine
(
)
and
problem
=
"end line before start line"
and
what
=
"at "
+
l
.
toString
(
)
or
l
.
getEndLine
(
)
=
l
.
getStartLine
(
)
and
l
.
getEndColumn
(
)
<
l
.
getStartColumn
(
)
and
problem
=
"end column before start column"
and
what
=
"at "
+
l
.
toString
(
)
)
}
predicate
cfg_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
ControlFlowNode
f
|
clsname
=
f
.
getAQlClass
(
)
|
uniqueness_error
(
count
(
f
.
getNode
(
)
)
,
"getNode"
,
problem
)
and
what
=
"at "
+
f
.
getLocation
(
)
.
toString
(
)
or
not
exists
(
f
.
getLocation
(
)
)
and
not
exists
(
Module
p
|
p
.
isPackage
(
)
|
p
.
getEntryNode
(
)
=
f
or
p
.
getAnExitNode
(
)
=
f
)
and
problem
=
"no location"
and
what
=
f
.
toString
(
)
or
uniqueness_error
(
count
(
f
.
(
AttrNode
)
.
getObject
(
)
)
,
"getValue"
,
problem
)
and
what
=
"at "
+
f
.
getLocation
(
)
.
toString
(
)
)
}
predicate
scope_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
Scope
s
|
clsname
=
s
.
getAQlClass
(
)
|
uniqueness_error
(
count
(
s
.
getEntryNode
(
)
)
,
"getEntryNode"
,
problem
)
and
what
=
"at "
+
s
.
getLocation
(
)
.
toString
(
)
or
uniqueness_error
(
count
(
s
.
toString
(
)
)
,
"toString"
,
problem
)
and
what
=
"at "
+
s
.
getLocation
(
)
.
toString
(
)
or
uniqueness_error
(
strictcount
(
s
.
getLocation
(
)
)
,
"getLocation"
,
problem
)
and
what
=
"at "
+
s
.
getLocation
(
)
.
toString
(
)
or
not
exists
(
s
.
getLocation
(
)
)
and
problem
=
"no location"
and
what
=
s
.
toString
(
)
and
not
s
.
(
Module
)
.
isPackage
(
)
)
}
string
best_description_builtin_object
(
Object
o
)
{
o
.
isBuiltin
(
)
and
(
result
=
o
.
toString
(
)
or
not
exists
(
o
.
toString
(
)
)
and
py_cobjectnames
(
o
,
result
)
or
not
exists
(
o
.
toString
(
)
)
and
not
py_cobjectnames
(
o
,
_
)
and
result
=
"builtin object of type "
+
o
.
getAnInferredType
(
)
.
toString
(
)
or
not
exists
(
o
.
toString
(
)
)
and
not
py_cobjectnames
(
o
,
_
)
and
not
exists
(
o
.
getAnInferredType
(
)
.
toString
(
)
)
and
result
=
"builtin object"
)
}
private
predicate
introspected_builtin_object
(
Object
o
)
{
/*
* Only check objects from the extractor, missing data for objects generated from C source code analysis is OK.
* as it will be ignored if it doesn't match up with the introspected form.
*/
py_cobject_sources
(
o
,
0
)
}
predicate
builtin_object_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
Object
o
|
clsname
=
o
.
getAQlClass
(
)
and
what
=
best_description_builtin_object
(
o
)
and
introspected_builtin_object
(
o
)
|
not
exists
(
o
.
getAnInferredType
(
)
)
and
not
py_cobjectnames
(
o
,
_
)
and
problem
=
"neither name nor type"
or
uniqueness_error
(
count
(
string
name
|
py_cobjectnames
(
o
,
name
)
)
,
"name"
,
problem
)
or
not
exists
(
o
.
getAnInferredType
(
)
)
and
problem
=
"no results for getAnInferredType"
or
not
exists
(
o
.
toString
(
)
)
and
problem
=
"no toString"
and
not
exists
(
string
name
|
name
.
matches
(
"\\_semmle%"
)
|
py_special_objects
(
o
,
name
)
)
and
not
o
=
unknownValue
(
)
)
}
predicate
source_object_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
Object
o
|
clsname
=
o
.
getAQlClass
(
)
and
not
o
.
isBuiltin
(
)
|
uniqueness_error
(
count
(
o
.
getOrigin
(
)
)
,
"getOrigin"
,
problem
)
and
what
=
"at "
+
o
.
getOrigin
(
)
.
getLocation
(
)
.
toString
(
)
or
not
exists
(
o
.
getOrigin
(
)
.
getLocation
(
)
)
and
problem
=
"no location"
and
what
=
"??"
or
not
exists
(
o
.
toString
(
)
)
and
problem
=
"no toString"
and
what
=
"at "
+
o
.
getOrigin
(
)
.
getLocation
(
)
.
toString
(
)
or
strictcount
(
o
.
toString
(
)
)
>
1
and
problem
=
"multiple toStrings()"
and
what
=
o
.
toString
(
)
)
}
predicate
ssa_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
/* Zero or one definitions of each SSA variable */
exists
(
SsaVariable
var
|
clsname
=
var
.
getAQlClass
(
)
|
uniqueness_error
(
strictcount
(
var
.
getDefinition
(
)
)
,
"getDefinition"
,
problem
)
and
what
=
var
.
getId
(
)
)
or
/* Dominance criterion: Definition *must* dominate *all* uses. */
exists
(
SsaVariable
var
,
ControlFlowNode
defn
,
ControlFlowNode
use
|
defn
=
var
.
getDefinition
(
)
and
use
=
var
.
getAUse
(
)
|
not
defn
.
strictlyDominates
(
use
)
and
not
defn
=
use
and
/* Phi nodes which share a flow node with a use come *before* the use */
not
(
exists
(
var
.
getAPhiInput
(
)
)
and
defn
=
use
)
and
clsname
=
var
.
getAQlClass
(
)
and
problem
=
"a definition which does not dominate a use at "
+
use
.
getLocation
(
)
and
what
=
var
.
getId
(
)
+
" at "
+
var
.
getLocation
(
)
)
or
/* Minimality of phi nodes */
exists
(
SsaVariable
var
|
strictcount
(
var
.
getAPhiInput
(
)
)
=
1
and
var
.
getAPhiInput
(
)
.
getDefinition
(
)
.
getBasicBlock
(
)
.
strictlyDominates
(
var
.
getDefinition
(
)
.
getBasicBlock
(
)
)
|
clsname
=
var
.
getAQlClass
(
)
and
problem
=
" a definition which is dominated by the definition of an incoming phi edge."
and
what
=
var
.
getId
(
)
+
" at "
+
var
.
getLocation
(
)
)
}
predicate
function_object_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
FunctionObject
func
|
clsname
=
func
.
getAQlClass
(
)
|
what
=
func
.
getName
(
)
and
(
not
exists
(
func
.
descriptiveString
(
)
)
and
problem
=
"no descriptiveString()"
or
exists
(
int
c
|
c
=
strictcount
(
func
.
descriptiveString
(
)
)
and
c
>
1
|
problem
=
c
+
"descriptiveString()s"
)
)
or
not
exists
(
func
.
getName
(
)
)
and
what
=
"?"
and
problem
=
"no name"
)
}
predicate
multiple_origins_per_object
(
Object
obj
)
{
not
obj
.
isC
(
)
and
not
obj
instanceof
ModuleObject
and
exists
(
ControlFlowNode
use
,
Context
ctx
|
strictcount
(
ControlFlowNode
orig
|
use
.
refersTo
(
ctx
,
obj
,
_
,
orig
)
)
>
1
)
}
predicate
intermediate_origins
(
ControlFlowNode
use
,
ControlFlowNode
inter
,
Object
obj
)
{
exists
(
ControlFlowNode
orig
,
Context
ctx
|
not
inter
=
orig
|
use
.
refersTo
(
ctx
,
obj
,
_
,
inter
)
and
inter
.
refersTo
(
ctx
,
obj
,
_
,
orig
)
and
// It can sometimes happen that two different modules (e.g. cPickle and Pickle)
// have the same attribute, but different origins.
not
strictcount
(
Object
val
|
inter
.
(
AttrNode
)
.
getObject
(
)
.
refersTo
(
val
)
)
>
1
)
}
predicate
points_to_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
Object
obj
|
multiple_origins_per_object
(
obj
)
and
clsname
=
obj
.
getAQlClass
(
)
and
problem
=
"multiple origins for an object"
and
what
=
obj
.
toString
(
)
)
or
exists
(
ControlFlowNode
use
,
ControlFlowNode
inter
|
intermediate_origins
(
use
,
inter
,
_
)
and
clsname
=
use
.
getAQlClass
(
)
and
problem
=
"has intermediate origin "
+
inter
and
what
=
use
.
toString
(
)
)
}
predicate
jump_to_definition_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
problem
=
"multiple (jump-to) definitions"
and
exists
(
Expr
use
|
strictcount
(
getUniqueDefinition
(
use
)
)
>
1
and
clsname
=
use
.
getAQlClass
(
)
and
what
=
use
.
toString
(
)
)
}
predicate
file_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
File
file
,
Folder
folder
|
clsname
=
file
.
getAQlClass
(
)
and
problem
=
"has same name as a folder"
and
what
=
file
.
getAbsolutePath
(
)
and
what
=
folder
.
getAbsolutePath
(
)
)
or
exists
(
Container
f
|
clsname
=
f
.
getAQlClass
(
)
and
uniqueness_error
(
count
(
f
.
toString
(
)
)
,
"toString"
,
problem
)
and
what
=
"file "
+
f
.
getAbsolutePath
(
)
)
}
predicate
class_value_consistency
(
string
clsname
,
string
problem
,
string
what
)
{
exists
(
ClassValue
value
,
ClassValue
sup
,
string
attr
|
what
=
value
.
getName
(
)
and
sup
=
value
.
getASuperType
(
)
and
exists
(
sup
.
lookup
(
attr
)
)
and
not
value
.
failedInference
(
_
)
and
not
exists
(
value
.
lookup
(
attr
)
)
and
clsname
=
value
.
getAQlClass
(
)
and
problem
=
"no attribute '"
+
attr
+
"', but super type '"
+
sup
.
getName
(
)
+
"' does."
)
}
from
string
clsname
,
string
problem
,
string
what
where
ast_consistency
(
clsname
,
problem
,
what
)
or
location_consistency
(
clsname
,
problem
,
what
)
or
scope_consistency
(
clsname
,
problem
,
what
)
or
cfg_consistency
(
clsname
,
problem
,
what
)
or
ssa_consistency
(
clsname
,
problem
,
what
)
or
builtin_object_consistency
(
clsname
,
problem
,
what
)
or
source_object_consistency
(
clsname
,
problem
,
what
)
or
function_object_consistency
(
clsname
,
problem
,
what
)
or
points_to_consistency
(
clsname
,
problem
,
what
)
or
jump_to_definition_consistency
(
clsname
,
problem
,
what
)
or
file_consistency
(
clsname
,
problem
,
what
)
or
class_value_consistency
(
clsname
,
problem
,
what
)
select
clsname
+
" "
+
what
+
" has "
+
problem
Back
|
FazBrowse Home
|
New Git URL