FazBrowse GitHub Viewer
|
Trending
|
URL:
|
Home
Tools:
[Download Repo ZIP]
[View Raw Code]
[Original HTTPS Page]
codeql/python/ql/src/Exceptions/EmptyExcept.ql at codeql-cli/v2.19.1 · github/codeql · GitHub
Uh oh!
There was an error while loading.
Please reload this page
.
github
/
codeql
Public
Notifications
You must be signed in to change notification settings
Fork
2.1k
Star
10k
Code
Issues
997
Pull requests
467
Discussions
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights
Expand file tree
Breadcrumbs
codeql
/
python
/
ql
/
src
/
Exceptions
/
EmptyExcept.ql
Copy path
More file actions
More file actions
Latest commit
History
History
History
107 lines (94 loc) · 3.29 KB
Breadcrumbs
codeql
/
python
/
ql
/
src
/
Exceptions
/
EmptyExcept.ql
Copy path
File metadata and controls
107 lines (94 loc) · 3.29 KB
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
/**
* @name Empty except
* @description Except doesn't do anything and has no comment
* @kind problem
* @tags reliability
* maintainability
* external/cwe/cwe-390
* @problem.severity recommendation
* @sub-severity high
* @precision high
* @id py/empty-except
*/
import
python
import
semmle.python.ApiGraphs
predicate
empty_except
(
ExceptStmt
ex
)
{
not
exists
(
Stmt
s
|
s
=
ex
.
getAStmt
(
)
and
not
s
instanceof
Pass
)
}
predicate
no_else
(
ExceptStmt
ex
)
{
not
exists
(
ex
.
getTry
(
)
.
getOrelse
(
)
)
}
predicate
no_comment
(
ExceptStmt
ex
)
{
not
exists
(
Comment
c
|
c
.
getLocation
(
)
.
getFile
(
)
=
ex
.
getLocation
(
)
.
getFile
(
)
and
c
.
getLocation
(
)
.
getStartLine
(
)
>=
ex
.
getLocation
(
)
.
getStartLine
(
)
and
c
.
getLocation
(
)
.
getEndLine
(
)
<=
ex
.
getBody
(
)
.
getLastItem
(
)
.
getLocation
(
)
.
getEndLine
(
)
)
}
predicate
non_local_control_flow
(
ExceptStmt
ex
)
{
ex
.
getType
(
)
=
API
::
builtin
(
"StopIteration"
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
}
predicate
try_has_normal_exit
(
Try
try
)
{
exists
(
ControlFlowNode
pred
,
ControlFlowNode
succ
|
/* Exists a non-exception predecessor, successor pair */
pred
.
getASuccessor
(
)
=
succ
and
not
pred
.
getAnExceptionalSuccessor
(
)
=
succ
|
/* Successor is either a normal flow node or a fall-through exit */
not
exists
(
Scope
s
|
s
.
getReturnNode
(
)
=
succ
)
and
/* Predecessor is in try body and successor is not */
pred
.
getNode
(
)
.
getParentNode
*
(
)
=
try
.
getAStmt
(
)
and
not
succ
.
getNode
(
)
.
getParentNode
*
(
)
=
try
.
getAStmt
(
)
)
}
predicate
attribute_access
(
Stmt
s
)
{
s
.
(
ExprStmt
)
.
getValue
(
)
instanceof
Attribute
or
exists
(
string
name
|
s
.
(
ExprStmt
)
.
getValue
(
)
.
(
Call
)
.
getFunc
(
)
.
(
Name
)
.
getId
(
)
=
name
|
name
=
"getattr"
or
name
=
"setattr"
or
name
=
"delattr"
)
or
s
.
(
Delete
)
.
getATarget
(
)
instanceof
Attribute
}
predicate
subscript
(
Stmt
s
)
{
s
.
(
ExprStmt
)
.
getValue
(
)
instanceof
Subscript
or
s
.
(
Delete
)
.
getATarget
(
)
instanceof
Subscript
}
predicate
encode_decode
(
Call
ex
,
Expr
type
)
{
exists
(
string
name
|
ex
.
getFunc
(
)
.
(
Attribute
)
.
getName
(
)
=
name
|
name
=
"encode"
and
type
=
API
::
builtin
(
"UnicodeEncodeError"
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
or
name
=
"decode"
and
type
=
API
::
builtin
(
"UnicodeDecodeError"
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
)
}
predicate
small_handler
(
ExceptStmt
ex
,
Stmt
s
,
Expr
type
)
{
not
exists
(
ex
.
getTry
(
)
.
getStmt
(
1
)
)
and
s
=
ex
.
getTry
(
)
.
getStmt
(
0
)
and
ex
.
getType
(
)
=
type
}
predicate
focussed_handler
(
ExceptStmt
ex
)
{
exists
(
Stmt
s
,
Expr
type
|
small_handler
(
ex
,
s
,
type
)
|
subscript
(
s
)
and
type
=
API
::
builtin
(
"IndexError"
)
.
getASubclass
*
(
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
or
attribute_access
(
s
)
and
type
=
API
::
builtin
(
"AttributeError"
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
or
s
.
(
ExprStmt
)
.
getValue
(
)
instanceof
Name
and
type
=
API
::
builtin
(
"NameError"
)
.
getAValueReachableFromSource
(
)
.
asExpr
(
)
or
encode_decode
(
s
.
(
ExprStmt
)
.
getValue
(
)
,
type
)
)
}
Try
try_return
(
)
{
not
exists
(
result
.
getStmt
(
1
)
)
and
result
.
getStmt
(
0
)
instanceof
Return
}
from
ExceptStmt
ex
where
empty_except
(
ex
)
and
no_else
(
ex
)
and
no_comment
(
ex
)
and
not
non_local_control_flow
(
ex
)
and
not
ex
.
getTry
(
)
=
try_return
(
)
and
try_has_normal_exit
(
ex
.
getTry
(
)
)
and
not
focussed_handler
(
ex
)
select
ex
,
"'except' clause does nothing but pass and there is no explanatory comment."
Back
|
FazBrowse Home
|
New Git URL