FazBrowse GitHub Viewer
|
Trending
|
URL:
|
Home
Tools:
[Download Repo ZIP]
[View Raw Code]
[Original HTTPS Page]
codeql/python/ql/src/Variables/ShadowGlobal.ql at codeql-cli/v2.25.1 · github/codeql · GitHub
Uh oh!
There was an error while loading.
Please reload this page
.
github
/
codeql
Public
Notifications
You must be signed in to change notification settings
Fork
2.1k
Star
10k
Code
Issues
998
Pull requests
461
Discussions
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights
Expand file tree
Breadcrumbs
codeql
/
python
/
ql
/
src
/
Variables
/
ShadowGlobal.ql
Copy path
More file actions
More file actions
Latest commit
History
History
History
76 lines (69 loc) · 2.41 KB
Breadcrumbs
codeql
/
python
/
ql
/
src
/
Variables
/
ShadowGlobal.ql
Copy path
File metadata and controls
76 lines (69 loc) · 2.41 KB
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
/**
* @name Global shadowed by local variable
* @description Defining a local variable with the same name as a global variable
* makes the global variable unusable within the current scope and makes the code
* more difficult to read.
* @kind problem
* @tags quality
* maintainability
* readability
* correctness
* @problem.severity recommendation
* @sub-severity low
* @precision medium
* @id py/local-shadows-global
*/
import
python
private
import
LegacyPointsTo
import
Shadowing
import
semmle.python.types.Builtins
predicate
shadows
(
Name
d
,
GlobalVariable
g
,
Function
scope
,
int
line
)
{
g
.
getScope
(
)
=
scope
.
getScope
(
)
and
d
.
getScope
(
)
=
scope
and
exists
(
LocalVariable
l
|
d
.
defines
(
l
)
and
l
.
getId
(
)
=
g
.
getId
(
)
)
and
not
exists
(
Import
il
,
Import
ig
,
Name
gd
|
il
.
contains
(
d
)
and
gd
.
defines
(
g
)
and
ig
.
contains
(
gd
)
)
and
not
exists
(
Assign
a
|
a
.
getATarget
(
)
=
d
and
a
.
getValue
(
)
=
g
.
getAnAccess
(
)
)
and
not
exists
(
Builtin
::
builtin
(
g
.
getId
(
)
)
)
and
d
.
getLocation
(
)
.
getStartLine
(
)
=
line
and
exists
(
Name
defn
|
defn
.
defines
(
g
)
|
not
exists
(
If
i
|
i
.
isNameEqMain
(
)
|
i
.
contains
(
defn
)
)
)
and
not
optimizing_parameter
(
d
)
}
/* pytest dynamically populates its namespace so, we cannot look directly for the pytest.fixture function */
AttrNode
pytest_fixture_attr
(
)
{
exists
(
ModuleValue
pytest
|
result
.
getObject
(
"fixture"
)
.
(
ControlFlowNodeWithPointsTo
)
.
pointsTo
(
pytest
)
)
}
Value
pytest_fixture
(
)
{
exists
(
CallNode
call
|
call
.
getFunction
(
)
=
pytest_fixture_attr
(
)
or
call
.
getFunction
(
)
.
(
CallNode
)
.
getFunction
(
)
=
pytest_fixture_attr
(
)
|
call
.
(
ControlFlowNodeWithPointsTo
)
.
pointsTo
(
result
)
)
}
/* pytest fixtures require that the parameter name is also a global */
predicate
assigned_pytest_fixture
(
GlobalVariable
v
)
{
exists
(
NameNode
def
|
def
.
defines
(
v
)
and
def
.
(
DefinitionNode
)
.
getValue
(
)
.
(
ControlFlowNodeWithPointsTo
)
.
pointsTo
(
pytest_fixture
(
)
)
)
}
predicate
first_shadowing_definition
(
Name
d
,
GlobalVariable
g
)
{
exists
(
int
first
,
Scope
scope
|
shadows
(
d
,
g
,
scope
,
first
)
and
first
=
min
(
int
line
|
shadows
(
_
,
g
,
scope
,
line
)
)
)
}
from
Name
d
,
GlobalVariable
g
,
Name
def
where
first_shadowing_definition
(
d
,
g
)
and
not
exists
(
Name
n
|
n
.
deletes
(
g
)
)
and
def
.
defines
(
g
)
and
not
assigned_pytest_fixture
(
g
)
and
not
g
.
getId
(
)
=
"_"
select
d
,
"Local variable '"
+
g
.
getId
(
)
+
"' shadows a $@."
,
def
,
"global variable"
Back
|
FazBrowse Home
|
New Git URL