FazBrowse GitHub Viewer
|
Trending
|
URL:
|
Home
Tools:
[Download Repo ZIP]
[View Raw Code]
[Original HTTPS Page]
codeql/java/ql/src/DeadCode/UselessParameter.qhelp at codeql-cli-2.11.3 · github/codeql · GitHub
github
/
codeql
Public
Notifications
You must be signed in to change notification settings
Fork
2.1k
Star
10.1k
Code
Issues
1k
Pull requests
468
Discussions
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights
Expand file tree
Breadcrumbs
codeql
/
java
/
ql
/
src
/
DeadCode
/
UselessParameter.qhelp
Copy path
More file actions
More file actions
Latest commit
History
History
History
39 lines (39 loc) · 1.54 KB
Breadcrumbs
codeql
/
java
/
ql
/
src
/
DeadCode
/
UselessParameter.qhelp
Copy path
File metadata and controls
39 lines (39 loc) · 1.54 KB
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
<!
DOCTYPE
qhelp
PUBLIC
"-//Semmle//qhelp//EN"
"qhelp.dtd">
<
qhelp
>
<
overview
>
<
p
>
Parameters that are never read in the body of the method, and are not required due to overriding,
are useless and can be removed. Useless parameters unnecessarily complicate the interface for that
method, and cause a maintenance and development burden.
</
p
>
<
p
>
Methods with useless parameters indicate that either the method can be simplified by removing the
parameter, or that the method is not using a value it should be using. Parameters of methods that
override other methods will not be marked as useless, because they are required. Similarly,
parameters of methods that are overridden by other methods are not marked as useless if they are
used by one of the overriding methods.
</
p
>
</
overview
>
<
recommendation
>
<
p
>
The method should be inspected to determine whether the parameter should be used within the body.
If the method is overridden, also consider whether any override methods should be using the
parameter. If the parameter is not required, it should be removed.
</
p
>
</
recommendation
>
<
example
>
<
p
>
In the following example, we have a method for determining whether a <
code
>String</
code
> path
is an absolute path:
</
p
>
<
sample
src
=
"
UselessParameter.java
"
/>
<
p
>
The method uses the parameter <
code
>path</
code
> to determine the return value. However, the
parameter <
code
>name</
code
> is not used within the body of the method. The parameter will be marked
as useless, and can be removed from the program.
</
p
>
</
example
>
<
include
src
=
"
DeadCodeReferences.inc.qhelp
"
/>
</
qhelp
>
Back
|
FazBrowse Home
|
New Git URL