FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

js: Inline expectation should have space after $ · github/codeql@0eccd90 · GitHub

/ codeql Public

Commit 0eccd90

Browse files
owen-mc
committed
js: Inline expectation should have space after $
This was a regex-find-replace from `// \$(?! )` (using a negative lookahead) to `// $ `.
1 parent 45eb149 commit 0eccd90

12 files changed

Lines changed: 156 additions & 156 deletions

File tree

‎javascript/ql/test/library-tests/frameworks/WebSocket/browser.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
11
(function () {
2-
const socket = new WebSocket('ws://localhost:8080'); // $clientSocket
2+
const socket = new WebSocket('ws://localhost:8080'); // $ clientSocket
33

44
socket.addEventListener('open', function (event) {
5-
socket.send('Hi from browser!'); // $clientSend
5+
socket.send('Hi from browser!'); // $ clientSend
66
});
77

88
socket.addEventListener('message', function (event) {
99
console.log('Message from server ', event.data); // $ remoteFlow
10-
}); // $clientReceive
10+
}); // $ clientReceive
1111

1212
socket.onmessage = function (event) {
1313
console.log("Message from server 2", event.data); // $ remoteFlow
14-
}; // $clientReceive
14+
}; // $ clientReceive
1515
})();
1616

1717

1818
(function () {
19-
var sock = new SockJS('http://0.0.0.0:9999/echo'); // $clientSocket
19+
var sock = new SockJS('http://0.0.0.0:9999/echo'); // $ clientSocket
2020
sock.onopen = function () {
21-
sock.send('test'); // $clientSend
21+
sock.send('test'); // $ clientSend
2222
};
23-
23+
2424
sock.onmessage = function (e) {
2525
console.log('message', e.data); // $ remoteFlow
2626
sock.close();
27-
}; // $clientReceive
28-
27+
}; // $ clientReceive
28+
2929
sock.addEventListener('message', function (event) {
3030
console.log('Using addEventListener ', event.data); // $ remoteFlow
31-
}); // $clientReceive
31+
}); // $ clientReceive
3232
})();
3333

3434
export const MyWebSocket = WebSocket;

‎javascript/ql/test/library-tests/frameworks/WebSocket/client.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
const WebSocket = require('ws');
22

33
(function () {
4-
const ws = new WebSocket('ws://example.org'); // $clientSocket
4+
const ws = new WebSocket('ws://example.org'); // $ clientSocket
55

66
ws.on('open', function open() {
7-
ws.send('Hi from client!'); // $clientSend
7+
ws.send('Hi from client!'); // $ clientSend
88
});
99

1010
ws.on('message', function incoming(data) { // $ remoteFlow
1111
console.log(data);
12-
}); // $clientReceive
12+
}); // $ clientReceive
1313
})();
1414

1515
module.exports.MyWebSocketWS = require('ws');

‎javascript/ql/test/library-tests/frameworks/WebSocket/server.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ const WebSocket = require('ws');
33
(function () {
44
const wss = new WebSocket.Server({ port: 8080 });
55

6-
wss.on('connection', function connection(ws) { // $serverSocket
7-
ws.on('message', function incoming(message) { // $remoteFlow
6+
wss.on('connection', function connection(ws) { // $ serverSocket
7+
ws.on('message', function incoming(message) { // $ remoteFlow
88
console.log('received: %s', message);
9-
}); // $serverReceive
9+
}); // $ serverReceive
1010

11-
ws.send('Hi from server!'); // $serverSend
11+
ws.send('Hi from server!'); // $ serverSend
1212
});
1313
})();
1414

‎javascript/ql/test/library-tests/frameworks/WebSocket/sockjs.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ const sockjs = require('sockjs');
55
const app = express();
66
const server = http.createServer(app);
77
const sockjs_echo = sockjs.createServer({});
8-
sockjs_echo.on('connection', function (conn) { // $serverSocket
9-
conn.on('data', function (message) { // $remoteFlow
8+
sockjs_echo.on('connection', function (conn) { // $ serverSocket
9+
conn.on('data', function (message) { // $ remoteFlow
1010
var data = JSON.parse(message);
11-
conn.write(JSON.stringify(eval(data.test))); // $serverSend
12-
}); // $serverReceive
11+
conn.write(JSON.stringify(eval(data.test))); // $ serverSend
12+
}); // $ serverReceive
1313
});
1414

1515
sockjs_echo.installHandlers(server, { prefix: '/echo' });

‎javascript/ql/test/query-tests/Declarations/SuspiciousMethodNameDeclaration/tst.ts‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ interface MyInterface {
77
constructor(): string; // $ Alert - This a called "constructor"
88
new(): Date; // OK - This a constructor signature.
99

10-
myNumber: 123;
10+
myNumber: 123;
1111
}
1212

1313
var a : MyFunction = null as any;
@@ -25,7 +25,7 @@ class Foo {
2525

2626
}
2727
myString = "foobar"
28-
28+
2929
myMethod(): boolean {
3030
return Math.random() > 0.5;
3131
}
@@ -71,17 +71,17 @@ class StaticMethods {
7171
}
7272

7373
interface Overloaded {
74-
function(x: string): string; // $Alert
75-
function(x: number): number; // $Alert
76-
function(x: any): any; // $Alert
74+
function(x: string): string; // $ Alert
75+
function(x: number): number; // $ Alert
76+
function(x: any): any; // $ Alert
7777
}
7878

7979
abstract class AbstractFoo {
80-
abstract new(): void; // $Alert
80+
abstract new(): void; // $ Alert
8181
}
8282

8383
abstract class AbstractFooFunction {
84-
abstract function(): number; // $Alert
84+
abstract function(): number; // $ Alert
8585
}
8686

8787
abstract class AbstractFooConstructor {
@@ -90,12 +90,12 @@ abstract class AbstractFooConstructor {
9090

9191
declare module "some-module" {
9292
interface ModuleInterface {
93-
function(): void; // $Alert
93+
function(): void; // $ Alert
9494
}
9595
}
9696

9797
type Intersection = {
98-
function(): number; // $Alert
98+
function(): number; // $ Alert
9999
} & {
100100
other(): string;
101101
};
@@ -107,13 +107,13 @@ type Union = {
107107
};
108108

109109
type Union2 = {
110-
constructor(): number; // $Alert
110+
constructor(): number; // $ Alert
111111
} | {
112112
valid(): string;
113113
};
114114

115115
type Intersection2 = {
116-
constructor(): number; // $Alert
116+
constructor(): number; // $ Alert
117117
} & {
118118
other(): string;
119119
};

‎javascript/ql/test/query-tests/Quality/UnhandledErrorInStreamPipeline/test.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
function test() {
22
{
33
const stream = getStream();
4-
stream.pipe(destination).on("error", e); // $Alert
4+
stream.pipe(destination).on("error", e); // $ Alert
55
}
66
{
77
const stream = getStream();
@@ -16,7 +16,7 @@ function test() {
1616
{
1717
const stream = getStream();
1818
const s2 = stream;
19-
s2.pipe(dest).on("error", e); // $Alert
19+
s2.pipe(dest).on("error", e); // $ Alert
2020
}
2121
{
2222
const stream = getStream();
@@ -33,7 +33,7 @@ function test() {
3333
{
3434
const s = getStream().on('error', handler);
3535
const d = getDest();
36-
s.pipe(d);
36+
s.pipe(d);
3737
}
3838
{
3939
getStream().on('error', handler).pipe(dest);
@@ -42,12 +42,12 @@ function test() {
4242
const stream = getStream();
4343
stream.on('error', handleError);
4444
const stream2 = stream.pipe(destination);
45-
stream2.pipe(destination2).on("error", e); // $Alert
45+
stream2.pipe(destination2).on("error", e); // $ Alert
4646
}
4747
{
4848
const stream = getStream();
4949
stream.on('error', handleError);
50-
const destination = getDest();
50+
const destination = getDest();
5151
destination.on('error', handleError);
5252
const stream2 = stream.pipe(destination);
5353
const s3 = stream2;
@@ -57,13 +57,13 @@ function test() {
5757
const stream = getStream();
5858
stream.on('error', handleError);
5959
const stream2 = stream.pipe(destination);
60-
stream2.pipe(destination2).on("error", e); // $Alert
60+
stream2.pipe(destination2).on("error", e); // $ Alert
6161
}
6262
{ // Error handler on destination instead of source
6363
const stream = getStream();
6464
const dest = getDest();
6565
dest.on('error', handler);
66-
stream.pipe(dest).on("error", e); // $Alert
66+
stream.pipe(dest).on("error", e); // $ Alert
6767
}
6868
{ // Multiple aliases, error handler on one
6969
const stream = getStream();
@@ -76,7 +76,7 @@ function test() {
7676
const stream = getStream();
7777
const s2 = stream.pipe(destination1);
7878
stream.on('error', handleError);
79-
s2.pipe(destination2).on("error", e); // $Alert
79+
s2.pipe(destination2).on("error", e); // $ Alert
8080
}
8181
{ // Handler registered via .once
8282
const stream = getStream();
@@ -91,32 +91,32 @@ function test() {
9191
{ // Handler registered for unrelated event
9292
const stream = getStream();
9393
stream.on('close', handleClose);
94-
stream.pipe(dest).on("error", e); // $Alert
94+
stream.pipe(dest).on("error", e); // $ Alert
9595
}
9696
{ // Error handler registered after pipe, but before error
9797
const stream = getStream();
9898
stream.pipe(dest);
99-
setTimeout(() => stream.on('error', handleError), 8000); // $MISSING:Alert
99+
setTimeout(() => stream.on('error', handleError), 8000); // $ MISSING:Alert
100100
}
101101
{ // Pipe in a function, error handler outside
102102
const stream = getStream();
103-
function doPipe(s) { s.pipe(dest); }
103+
function doPipe(s) { s.pipe(dest); }
104104
stream.on('error', handleError);
105105
doPipe(stream);
106106
}
107107
{ // Pipe in a function, error handler not set
108108
const stream = getStream();
109-
function doPipe(s) {
110-
f = s.pipe(dest); // $Alert
111-
f.on("error", e);
109+
function doPipe(s) {
110+
f = s.pipe(dest); // $ Alert
111+
f.on("error", e);
112112
}
113113
doPipe(stream);
114114
}
115115
{ // Dynamic event assignment
116116
const stream = getStream();
117117
const event = 'error';
118118
stream.on(event, handleError);
119-
stream.pipe(dest).on("error", e); // $SPURIOUS:Alert
119+
stream.pipe(dest).on("error", e); // $ SPURIOUS:Alert
120120
}
121121
{ // Handler assigned via variable property
122122
const stream = getStream();
@@ -125,7 +125,7 @@ function test() {
125125
stream.pipe(dest);
126126
}
127127
{ // Pipe with no intermediate variable, no error handler
128-
getStream().pipe(dest).on("error", e); // $Alert
128+
getStream().pipe(dest).on("error", e); // $ Alert
129129
}
130130
{ // Handler set via .addListener synonym
131131
const stream = getStream();
@@ -143,7 +143,7 @@ function test() {
143143
}
144144
{ // Long chained pipe without error handler
145145
const stream = getStream();
146-
stream.pause().setEncoding('utf8').resume().pipe(writable).on("error", e); // $Alert
146+
stream.pause().setEncoding('utf8').resume().pipe(writable).on("error", e); // $ Alert
147147
}
148148
{ // Long chained pipe without error handler
149149
const stream = getStream();
@@ -157,13 +157,13 @@ function test() {
157157
const notStream = getNotAStream();
158158
const result = notStream.pipe(writable);
159159
const dealWithResult = (result) => { result.subscribe(); };
160-
dealWithResult(result);
160+
dealWithResult(result);
161161
}
162162
{ // Non-stream with pipe method that returns subscribable object (Streams do not have subscribe method)
163163
const notStream = getNotAStream();
164164
const pipeIt = (someVariable) => { return someVariable.pipe(something); };
165165
let x = pipeIt(notStream);
166-
x.subscribe();
166+
x.subscribe();
167167
}
168168
{ // Calling custom pipe method with no arguments
169169
const notStream = getNotAStream();
@@ -179,7 +179,7 @@ function test() {
179179
}
180180
{ // Member access on a stream after pipe
181181
const notStream = getNotAStream();
182-
const val = notStream.pipe(writable).on("error", e).readable; // $Alert
182+
const val = notStream.pipe(writable).on("error", e).readable; // $ Alert
183183
}
184184
{ // Method access on a non-stream after pipe
185185
const notStream = getNotAStream();
@@ -189,14 +189,14 @@ function test() {
189189
const fs = require('fs');
190190
const stream = fs.createReadStream('file.txt');
191191
const copyStream = stream;
192-
copyStream.pipe(destination).on("error", e); // $Alert
192+
copyStream.pipe(destination).on("error", e); // $ Alert
193193
}
194194
{
195195
const notStream = getNotAStream();
196196
const something = notStream.someNotStreamPropertyAccess;
197197
const val = notStream.pipe(writable);
198198
}
199-
{
199+
{
200200
const notStream = getNotAStream();
201201
const something = notStream.someNotStreamPropertyAccess();
202202
const val = notStream.pipe(writable);
@@ -207,7 +207,7 @@ function test() {
207207
}
208208
{
209209
const notStream = getNotAStream();
210-
notStream.pipe(()=>{});
210+
notStream.pipe(() => { });
211211
}
212212
{
213213
const plumber = require('gulp-plumber');
@@ -230,6 +230,6 @@ function test() {
230230
}
231231
{
232232
const notStream = getNotAStream();
233-
notStream.pipe(getStream(),()=>{});
233+
notStream.pipe(getStream(), () => { });
234234
}
235235
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL