Commit f0e665d
File tree
- javascript/ql
- lib
- change-notes
- semmle/javascript/frameworks
- test/library-tests/frameworks/ReactJS
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,4 @@ | |||
| 1 | + --- | ||
| 2 | + category: minorAnalysis | ||
| 3 | + --- | ||
| 4 | + * Added support for React components wrapped by `observer` from `mobx-react` and `mobx-react-lite`. | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -832,6 +832,8 @@ private DataFlow::SourceNode higherOrderComponentBuilder() { | |||
| 832 | 832 | or | |
| 833 | 833 | result = DataFlow::moduleMember("recompose", _).getACall() | |
| 834 | 834 | or | |
| 835 | + result = DataFlow::moduleMember(["mobx-react", "mobx-react-lite"], "observer") | ||
| 836 | + or | ||
| 835 | 837 | result = reactRouterDom().getAPropertyRead("withRouter") | |
| 836 | 838 | or | |
| 837 | 839 | exists(FunctionCompositionCall compose | | |
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,6 +5,8 @@ import styled from 'styled-components'; | |||
| 5 | 5 | import unknownFunction from 'somewhere'; | |
| 6 | 6 | import { hot } from 'react-hot-loader'; | |
| 7 | 7 | import { withState } from 'recompose'; | |
| 8 | + import { observer as observer1 } from 'mobx-react'; | ||
| 9 | + import { observer as observer2 } from 'mobx-react-lite'; | ||
| 8 | 10 | ||
| 9 | 11 | import { MyComponent } from './exportedComponent'; | |
| 10 | 12 | ||
@@ -25,4 +27,6 @@ const ConnectedComponent = compose(withConnect, unknownFunction)(StyledComponent | |||
| 25 | 27 | ||
| 26 | 28 | const ConnectedComponent2 = withState('counter', 'setCounter', 0)(ConnectedComponent); | |
| 27 | 29 | ||
| 28 | - export default hot(module)(memo(forwardRef(ConnectedComponent2))); | ||
| 30 | + const ConnectedComponent3 = observer1(observer2(ConnectedComponent2)); | ||
| 31 | + | ||
| 32 | + export default hot(module)(memo(forwardRef(ConnectedComponent3))); | ||
0 commit comments