Handle API versions that reject unsuccessful executions · github/codeql-action@91edebd · GitHub

github / codeql-action Public

• Notifications You must be signed in to change notification settings
• Fork 493
• Star 1.6k

• Code
• Issues 157
• Pull requests 32
• Actions
• Security and quality 2
• Insights

Additional navigation options

Commit 91edebd

Browse filesBrowse the repository at this point in the historyBrowse files

henrymercer

committed

Handle API versions that reject unsuccessful executions

1 parent 7cef3cf commit 91edebd
Copy full SHA for 91edebd

3 files changed

+27-7Lines changed: 27 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • init-action-post-helper.js.map
  • init-action-post-helper.js
• src
  • init-action-post-helper.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/init-action-post-helper.js‎

Copy file name to clipboardExpand all lines: lib/init-action-post-helper.js

+11-1Lines changed: 11 additions & 1 deletion

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎lib/init-action-post-helper.js.map‎

Copy file name to clipboardExpand all lines: lib/init-action-post-helper.js.map

+1-1Lines changed: 1 addition & 1 deletion

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎src/init-action-post-helper.ts‎

Copy file name to clipboardExpand all lines: src/init-action-post-helper.ts

+15-5Lines changed: 15 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -63,11 +63,21 @@ async function uploadFailedSarif(
63	63	logger
64	64	);
65	65	if (uploadResult !== undefined && waitForProcessing) {
66		- await uploadLib.waitForProcessing(
67		- repositoryNwo,
68		- uploadResult.sarifID,
69		- logger
70		- );
	66	+ try {
	67	+ await uploadLib.waitForProcessing(
	68	+ repositoryNwo,
	69	+ uploadResult.sarifID,
	70	+ logger
	71	+ );
	72	+ } catch (e) {
	73	+ if (e instanceof Error && e.message.includes("unsuccessful execution")) {
	74	+ logger.info(
	75	+ "Submitting a SARIF file for the failed run isn't yet supported, continuing."
	76	+ );
	77	+ } else {
	78	+ throw e;
	79	+ }
	80	+ }
71	81	}
72	82	}
73	83

0 commit comments

Comments

0 (0)