Remove the overlay_analysis_resource_checks_v2 feature flag · github/codeql-action@99caaa8 · GitHub

github / codeql-action Public

• Notifications You must be signed in to change notification settings
• Fork 487
• Star 1.6k

• Code
• Issues 158
• Pull requests 35
• Actions
• Security and quality 2
• Insights

Additional navigation options

Commit 99caaa8

Browse filesBrowse the repository at this point in the historyBrowse files

henrymercer

and

Copilot

committed

Remove the overlay_analysis_resource_checks_v2 feature flag

The flag no longer has any effect now that its 14 GB threshold is the unconditional default, so remove it. Setting CODEQL_ACTION_OVERLAY_ANALYSIS_RESOURCE_CHECKS_V2 no longer does anything. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

1 parent 6117bb5 commit 99caaa8
Copy full SHA for 99caaa8

2 files changed

-15Lines changed: 0 additions & 15 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • entry-points.js
• src
  • feature-flags.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/entry-points.js‎

Copy file name to clipboardExpand all lines: lib/entry-points.js

-5Lines changed: 0 additions & 5 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎src/feature-flags.ts‎

Copy file name to clipboardExpand all lines: src/feature-flags.ts

-10Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -134,11 +134,6 @@ export enum Feature {
134	134	OverlayAnalysisMinDisk12Gb = "overlay_analysis_min_disk_12_gb",
135	135	OverlayAnalysisMinDisk13Gb = "overlay_analysis_min_disk_13_gb",
136	136	OverlayAnalysisPython = "overlay_analysis_python",
137		- /**
138		- * Controls whether lower disk space requirements are used for overlay hardware checks.
139		- * Has no effect if `OverlayAnalysisSkipResourceChecks` is enabled.
140		- */
141		- OverlayAnalysisResourceChecksV2 = "overlay_analysis_resource_checks_v2",
142	137	OverlayAnalysisRuby = "overlay_analysis_ruby",
143	138	/** Controls whether hardware checks are skipped for overlay analysis. */
144	139	OverlayAnalysisSkipResourceChecks = "overlay_analysis_skip_resource_checks",
@@ -396,11 +391,6 @@ export const featureConfig = {
396	391	envVar: "CODEQL_ACTION_OVERLAY_ANALYSIS_MIN_DISK_13_GB",
397	392	minimumVersion: undefined,
398	393	},
399		- [Feature.OverlayAnalysisResourceChecksV2]: {
400		- defaultValue: false,
401		- envVar: "CODEQL_ACTION_OVERLAY_ANALYSIS_RESOURCE_CHECKS_V2",
402		- minimumVersion: undefined,
403		- },
404	394	[Feature.OverlayAnalysisStatusCheck]: {
405	395	defaultValue: false,
406	396	envVar: "CODEQL_ACTION_OVERLAY_ANALYSIS_STATUS_CHECK",

0 commit comments

Comments

0 (0)