Commit 01c95eb
committed
Don't patch IndexObject and Object into git.objects.submodule.util
Such patching, which was introduced in 9519f18, seems no longer to
be necessary. Since git.objects.submodule.util.__all__ has existed
for a long time without including those names, they are not
conceptually public attributes of git.objects.submodule.util, so
they should not be in use by any code outside GitPython either.
The modattrs.py script shows the change, as expected, showing these
two names as no longer being in the git.objects.submodule.util
module dictionary, in output of:
python modattrs.py >b
git diff --no-index a b
However, because the removal is intentional, this is okay.1 parent c58be4c commit 01c95eb
1 file changed
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,17 +8,10 @@ | |||
| 8 | 8 | from .base import * # noqa: F403 | |
| 9 | 9 | from .blob import * # noqa: F403 | |
| 10 | 10 | from .commit import * # noqa: F403 | |
| 11 | - from .submodule import util as smutil | ||
| 12 | 11 | from .submodule.base import * # noqa: F403 | |
| 13 | 12 | from .submodule.root import * # noqa: F403 | |
| 14 | 13 | from .tag import * # noqa: F403 | |
| 15 | 14 | from .tree import * # noqa: F403 | |
| 16 | 15 | ||
| 17 | - # Fix import dependency - add IndexObject to the util module, so that it can be imported | ||
| 18 | - # by the submodule.base. | ||
| 19 | - smutil.IndexObject = IndexObject # type: ignore[attr-defined] # noqa: F405 | ||
| 20 | - smutil.Object = Object # type: ignore[attr-defined] # noqa: F405 | ||
| 21 | - del smutil | ||
| 22 | - | ||
| 23 | 16 | # Must come after submodule was made available. | |
| 24 | 17 | __all__ = [name for name, obj in locals().items() if not (name.startswith("_") or inspect.ismodule(obj))] | |
0 commit comments