Commit 1ddf953
committed
Fix TemporaryFileSwap bug when file_path is a Path
This fixes the regression introduced in 9e86053 (#1770) where the
file_path argument to TemporaryFileSwap.__init__ could no longer be
a Path object.
The change also makes this truer to the code from before #1770,
still without the race condition fixed there, in that str was
called on file_path then as well. However, it is not clear that
this is a good thing, because this is not an idiomatic use of
mkstemp. The reason the `prefix` cannot be a Path is that it is
expected to be a filename prefix, with leading directories given in
the `dir` argument.1 parent 487a4fd commit 1ddf953
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,7 +41,7 @@ class TemporaryFileSwap: | |||
| 41 | 41 | ||
| 42 | 42 | def __init__(self, file_path: PathLike) -> None: | |
| 43 | 43 | self.file_path = file_path | |
| 44 | - fd, self.tmp_file_path = tempfile.mkstemp(prefix=self.file_path, dir="") | ||
| 44 | + fd, self.tmp_file_path = tempfile.mkstemp(prefix=str(self.file_path), dir="") | ||
| 45 | 45 | os.close(fd) | |
| 46 | 46 | with contextlib.suppress(OSError): # It may be that the source does not exist. | |
| 47 | 47 | os.replace(self.file_path, self.tmp_file_path) | |
0 commit comments