| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 3eb7c2a commit 1f3caa3
1 file changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1032,16 +1032,16 @@ def test_hook_uses_shell_not_from_cwd(self, rw_dir, case): | |||
| 1032 | 1032 | maybe_chdir = cwd(rw_dir) if chdir_to_repo else contextlib.nullcontext() | |
| 1033 | 1033 | repo = Repo.init(rw_dir) | |
| 1034 | 1034 | ||
| 1035 | - # We need an impostor shell that works on Windows and that can be distinguished | ||
| 1036 | - # from the real bash.exe. But even if the real bash.exe is absent or unusable, | ||
| 1037 | - # we should verify that the impostor is not run. So the impostor needs a clear | ||
| 1038 | - # side effect (unlike in TestGit.test_it_executes_git_not_from_cwd). Popen on | ||
| 1039 | - # Windows uses CreateProcessW, which disregards PATHEXT; the impostor may need | ||
| 1040 | - # to be a binary executable to ensure the vulnerability is found if present. No | ||
| 1041 | - # compiler need exist, shipping a binary in the test suite may target the wrong | ||
| 1042 | - # architecture, and generating one in a bespoke way may cause virus scanners to | ||
| 1043 | - # give a false positive. So we use a Bash/Python polyglot for the hook and use | ||
| 1044 | - # the Python interpreter itself as the bash.exe impostor. But an interpreter | ||
| 1035 | + # We need an impostor shell that works on Windows and that the test can | ||
| 1036 | + # distinguish from the real bash.exe. But even if the real bash.exe is absent or | ||
| 1037 | + # unusable, we should verify the impostor is not run. So the impostor needs a | ||
| 1038 | + # clear side effect (unlike in TestGit.test_it_executes_git_not_from_cwd). Popen | ||
| 1039 | + # on Windows uses CreateProcessW, which disregards PATHEXT; the impostor may | ||
| 1040 | + # need to be a binary executable to ensure the vulnerability is found if | ||
| 1041 | + # present. No compiler need exist, shipping a binary in the test suite may | ||
| 1042 | + # target the wrong architecture, and generating one in a bespoke way may trigger | ||
| 1043 | + # false positive virus scans. So we use a Bash/Python polyglot for the hook and | ||
| 1044 | + # use the Python interpreter itself as the bash.exe impostor. But an interpreter | ||
| 1045 | 1045 | # from a venv may not run when copied outside of it, and a global interpreter | |
| 1046 | 1046 | # won't run when copied to a different location if it was installed from the | |
| 1047 | 1047 | # Microsoft Store. So we make a new venv in rw_dir and use its interpreter. | |
| Back | FazBrowse Home | New Git URL |
0 commit comments