Don't preinstall dependencies in test_installation · gitpython-developers/GitPython@21c5f87 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 21c5f87

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Don't preinstall dependencies in test_installation

This removes the step in test_installation that did the equivalent of "pip install -r requirements.txt", because installing GitPython is sufficient to install all its required dependencies, and it is more important to test that than to test requirements.txt directly. Removing this causes the test to fail if installing the project doesn't entail installation of the requirements necessary to import the git module or to cause gitdb to be found in a sys.path search.

1 parent b9b6d8c commit 21c5f87
Copy full SHA for 21c5f87

1 file changed

-10Lines changed: 0 additions & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_installation.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_installation.py‎

Copy file name to clipboardExpand all lines: test/test_installation.py

-10Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -23,16 +23,6 @@ def setUp_venv(self, rw_dir):
23	23	@with_rw_directory
24	24	def test_installation(self, rw_dir):
25	25	self.setUp_venv(rw_dir)
26		- result = subprocess.run(
27		- [self.pip, "install", "-r", "requirements.txt"],
28		- stdout=subprocess.PIPE,
29		- cwd=self.sources,
30		- )
31		- self.assertEqual(
32		- 0,
33		- result.returncode,
34		- msg=result.stderr or result.stdout or "Can't install requirements",
35		- )
36	26	result = subprocess.run(
37	27	[self.pip, "install", "."],
38	28	stdout=subprocess.PIPE,

0 commit comments

Comments

0 (0)