Repository navigation
Commit 2ed3334
committed
Fix order of environment setup and git module import
The environment setup must happen before the `git` module is imported,
otherwise GitPython won't be able to find the Git executable and raise
an exception that causes the ClusterFuzz fuzzer runs to fail.1 parent 27de867 commit 2ed3334
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,6 @@ | |||
| 3 | 3 | import os | |
| 4 | 4 | import tempfile | |
| 5 | 5 | from configparser import ParsingError | |
| 6 | - from git import Repo, GitCommandError, InvalidGitRepositoryError | ||
| 7 | 6 | from utils import ( | |
| 8 | 7 | setup_git_environment, | |
| 9 | 8 | handle_exception, | |
@@ -12,6 +11,7 @@ | |||
| 12 | 11 | ||
| 13 | 12 | # Setup the git environment | |
| 14 | 13 | setup_git_environment() | |
| 14 | + from git import Repo, GitCommandError, InvalidGitRepositoryError | ||
| 15 | 15 | ||
| 16 | 16 | ||
| 17 | 17 | def TestOneInput(data): | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -78,6 +78,10 @@ lint.unfixable = [ | |||
| 78 | 78 | "test/**" = [ | |
| 79 | 79 | "B018", # useless-expression | |
| 80 | 80 | ] | |
| 81 | + "fuzzing/fuzz-targets/**" = [ | ||
| 82 | + "E402", # environment setup must happen before the `git` module is imported, thus cannot happen at top of file | ||
| 83 | + ] | ||
| 84 | + | ||
| 81 | 85 | ||
| 82 | 86 | [tool.codespell] | |
| 83 | 87 | ignore-words-list="gud,doesnt" | |
0 commit comments