Test that extra prefix "WARNING:" is omitted · gitpython-developers/GitPython@3250313 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 992
• Star 5.2k

• Code
• Issues 7
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 3250313

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Test that extra prefix "WARNING:" is omitted

This changes test_initial_refresh_from_bad_git_path_env_warn to assert a message with no added "WARNING:" prefix. As discussed in #1815, the extra prefix is confusing with logging configured, showing "CRITICAL:git.cmd:WARNING: Bad git executable." instead of "CRITICAL:git.cmd: Bad git executable."

1 parent db36174 commit 3250313
Copy full SHA for 3250313

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_git.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_git.py‎

Copy file name to clipboardExpand all lines: test/test_git.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -363,7 +363,7 @@ def test_initial_refresh_from_bad_git_path_env_warn(self, case):
363	363	refresh()
364	364	self.assertEqual(len(ctx.records), 1)
365	365	message = ctx.records[0].getMessage()
366		- self.assertRegex(message, r"\AWARNING: Bad git executable.\n")
	366	+ self.assertRegex(message, r"\ABad git executable.\n")
367	367	self.assertEqual(self.git.GIT_PYTHON_GIT_EXECUTABLE, "git")
368	368
369	369	@ddt.data(("2",), ("r",), ("raise",), ("e",), ("error",))

0 commit comments

Comments

0 (0)