Fixed premature closing of stdout/stderr streams, which caused plenty… · gitpython-developers/GitPython@3287148 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests1 (1)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 3287148

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Fixed premature closing of stdout/stderr streams, which caused plenty of errors.

The lines were added in commit b38020a , and I might consider a patch release soon or get ready with 0.3.3. Lets hope not too many installations will be affected.

1 parent 598cd1d commit 3287148
Copy full SHA for 3287148

1 file changed

-2Lines changed: 0 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • cmd.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -106,8 +106,6 @@ def wait(self):
106	106
107	107	:raise GitCommandError: if the return status is not 0"""
108	108	status = self.proc.wait()
109		- self.proc.stdout.close()
110		- self.proc.stderr.close()
111	109	if status != 0:
112	110	raise GitCommandError(self.args, status, self.proc.stderr.read())
113	111	# END status handling

0 commit comments

Comments

0 (0)